Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add additional Azure authentication methods #2333

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

kevinzwang
Copy link
Member

Adds:

  • login via shared access signatures (SAS)
  • login via Entra ID (active directory) using tenant id + client id + client secret
  • fallback to environment variables using azure-sdk-for-rust

Tested locally 👍

@kevinzwang kevinzwang requested a review from samster25 June 3, 2024 09:24
@github-actions github-actions bot added the enhancement New feature or request label Jun 3, 2024
}
if let Some(client_secret) = &self.client_secret {
res.push(format!("Client Secret = {}", client_secret));
}
res.push(format!("Anoynmous = {}", self.anonymous));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we may have this Anoynmous typo in a few places!

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 12.03704% with 95 lines in your changes missing coverage. Please review.

Project coverage is 79.04%. Comparing base (540e65c) to head (b036447).

Current head b036447 differs from pull request most recent head 98325be

Please upload reports for the commit 98325be to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2333      +/-   ##
==========================================
- Coverage   79.16%   79.04%   -0.13%     
==========================================
  Files         473      473              
  Lines       54861    54960      +99     
==========================================
+ Hits        43433    43442       +9     
- Misses      11428    11518      +90     
Files Coverage Δ
daft/io/_iceberg.py 85.71% <75.00%> (-1.52%) ⬇️
daft/io/object_store_options.py 59.25% <0.00%> (-10.31%) ⬇️
src/common/io-config/src/azure.rs 21.53% <13.79%> (-5.49%) ⬇️
src/common/io-config/src/python.rs 58.19% <0.00%> (-3.64%) ⬇️
src/daft-io/src/azure_blob.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@kevinzwang kevinzwang enabled auto-merge (squash) June 3, 2024 18:40
@kevinzwang kevinzwang merged commit 55b0bc4 into main Jun 3, 2024
42 checks passed
@kevinzwang kevinzwang deleted the kevin/azure-managed-identity branch June 3, 2024 18:57
@kevinzwang kevinzwang linked an issue Jun 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reading from Azure with adlsv2 managed identity
2 participants