[BUG] Translate mssql to tsql in read_sql scan #2330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
read_sql
against SQL server using a SQL Alchemy connection, for example:The query errors with
Unsupported dialect: mssql, please refer to the documentation for supported dialects
.This is because SQLGlot, the library that read_sql uses for query construction, does not recognize
mssql
as a dialect, it instead recognizestsql
, which is the name of the SQL dialect for Microsoft SQL Server: https://learn.microsoft.com/en-us/sql/t-sql/language-reference?view=sql-server-ver16This PR adds a translation step during sql query construction to fix this issue.
NOTE: