[FEAT] Expression between #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of value comparison
github-actions
bot
added
the
documentation
|
@colin-ho can you take a look! |
colin-ho
reviewed
May 29, 2024
There was a problem hiding this comment.
Awesome work @GuyPozner, this is a great PR! just left a couple of comments :)
colin-ho
approved these changes
May 30, 2024
|
And congrats on first PR 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1903
It still WIP, I just want to get some feedback to know if I am on the right path, I have a feeling I might have overdone it with defining Between as its own trait.
Edit:
Can someone point me to a rust test that covers the DaftError cases?