[CHORE] Add TPC-H questions 11-22 to benchmarks (currently skipped) #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinzwang
changed the title
jaychia
approved these changes
May 24, 2024
Is it possible to cache the build and run each question in its own action? |
|
Update from discussion: will look into questions 17, 20, 22 to see if there is a simple way to improve their speeds first before merging |
samster25
reviewed
Jun 3, 2024
benchmarking/tpch/answers.py
Outdated
| res_1.where(col("C_ACCTBAL") > 0).agg(col("C_ACCTBAL").mean().alias("avg_acctbal")).with_column("lit", lit(1)) | ||
| ) | ||
|
|
||
| res_3 = orders.select("O_CUSTKEY").distinct() |
There was a problem hiding this comment.
discussed offline but we can likely remove these distinct since we are doing a not exists and dont care about the dup values.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2299 +/- ##
==========================================
+ Coverage 78.47% 79.05% +0.58%
==========================================
Files 473 473
Lines 56045 55150 -895
==========================================
- Hits 43981 43600 -381
+ Misses 12064 11550 -514 |
kevinzwang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.