Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix multi-output tasks in RayRunner #2291

Merged
merged 2 commits into from
May 22, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented May 22, 2024

Fixes a user-reported bug around into_partitions failing on the Ray runner for a specific corner-case: when some input partition wasn't split, the RayRunner was performing an overly-aggressive assert that should be relaxed.

@github-actions github-actions bot added the bug Something isn't working label May 22, 2024
@jaychia jaychia enabled auto-merge (squash) May 22, 2024 02:29
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@df9aa15). Learn more about missing BASE report.

Current head 9a16349 differs from pull request most recent head 056e09b

Please upload reports for the commit 056e09b to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2291   +/-   ##
=======================================
  Coverage        ?   79.11%           
=======================================
  Files           ?      467           
  Lines           ?    53857           
  Branches        ?        0           
=======================================
  Hits            ?    42610           
  Misses          ?    11247           
  Partials        ?        0           
Files Coverage Δ
daft/runners/ray_runner.py 90.31% <100.00%> (ø)

@jaychia jaychia merged commit f5b8dfa into main May 22, 2024
44 checks passed
@jaychia jaychia deleted the jay/fix-multi-output-ray-runner branch May 22, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant