Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] turn on cov again #2259

Merged
merged 13 commits into from
May 9, 2024
Merged

[CHORE] turn on cov again #2259

merged 13 commits into from
May 9, 2024

Conversation

samster25
Copy link
Member

@samster25 samster25 commented May 9, 2024

  • It seems like downgrading to ubuntu 20.04 seems to fix the segfault we were seeing with the collection!

@github-actions github-actions bot added the chore label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.17%. Comparing base (dc2dbe5) to head (82c0f6b).

❗ Current head 82c0f6b differs from pull request most recent head 40d2e11. Consider uploading reports for the commit 40d2e11 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2259      +/-   ##
==========================================
- Coverage   85.73%   79.17%   -6.56%     
==========================================
  Files          71      459     +388     
  Lines        7702    53203   +45501     
==========================================
+ Hits         6603    42122   +35519     
- Misses       1099    11081    +9982     

see 388 files with indirect coverage changes

@samster25 samster25 marked this pull request as ready for review May 9, 2024 05:11
@samster25 samster25 merged commit 5c91b47 into main May 9, 2024
44 checks passed
@samster25 samster25 deleted the sammy/try-llvm-cov branch May 9, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant