Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.sqrt() expression #2180

Merged
merged 7 commits into from
May 1, 2024
Merged

.sqrt() expression #2180

merged 7 commits into from
May 1, 2024

Conversation

dmaymay
Copy link
Contributor

@dmaymay dmaymay commented Apr 25, 2024

Working .sqrt() function. Casting integers to appropriate float types :)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 25, 2024
@dmaymay dmaymay marked this pull request as ready for review April 26, 2024 02:53
@colin-ho colin-ho self-requested a review April 26, 2024 15:53
Copy link
Contributor

@colin-ho colin-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @dmaymay ! Just a few nits

src/daft-dsl/src/functions/numeric/sqrt.rs Outdated Show resolved Hide resolved
src/daft-dsl/src/functions/numeric/sqrt.rs Outdated Show resolved Hide resolved
@colin-ho colin-ho added the enhancement New feature or request label Apr 26, 2024
@colin-ho
Copy link
Contributor

Hey @dmaymay ! This PR looks ready to merge, if you could just help remove this one line here that's no longer needed that'd be great. Also seems like there's a merge conflict, I checked it out and it should just be a simple one line change :)

@dmaymay
Copy link
Contributor Author

dmaymay commented May 1, 2024

@colin-ho We good to merge?

@colin-ho colin-ho merged commit e3756f5 into Eventual-Inc:main May 1, 2024
25 checks passed
@colin-ho
Copy link
Contributor

colin-ho commented May 1, 2024

@colin-ho We good to merge?

Yep! Just did a rebase to inspect the file changes a lil easier, but all good and merged now, thanks @dmaymay 😆

@colin-ho
Copy link
Contributor

colin-ho commented May 1, 2024

Also congrats on first PR!!

@jaychia
Copy link
Contributor

jaychia commented May 1, 2024

Congrats on your first PR 🤓 @dmaymay

@samster25
Copy link
Member

great job @dmaymay!

@colin-ho colin-ho mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants