Add support to CuPy as input and other changes related. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scikit-image deprecated both methods: skimage.feature.graycomatrix and skimage.feature.graycoprops. The project replaced them to skimage.feature.greycomatrix and skimage.feature.greycoprops. It is just a new name convention. That's why this commit just introduce an alias for older releases. Signed-off-by: Julio Faracco <[email protected]>
There is a problem when you pass a image which is already a cupy type. This commit just introduce the union type for most of the functions and types. It also includes cuCIM from NVIDIA RAPIDS which is the new implementation of cuimg, a cupy project that reflects scikit-image. Signed-off-by: Julio Faracco <[email protected]>
This commit just adds some test cases to cover cupy inputs. The only exception is the function test_output_match_cp(). It needs to be converted to numpy because pytest.approx only supports numpy. As it is just a test case, there is no problem to get data from GPU to test. Signed-off-by: Julio Faracco <[email protected]>
|
@jcfaracco Thanks for doing this, been extremely busy these days. |
|
Thanks @Eve-ning. I also appreciate your changes after mine. Sorry... I simply forgot to change the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series just add support to CuPy input using Union structure. It also uses some functions dedicated to process image using a CPU only. For this all data can stay in GPU.
This patchset fixes issue #17.