Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini refactor #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gordicaleksa
Copy link

@gordicaleksa gordicaleksa commented Jul 17, 2024

Mini refactor:

  • Add informative error messages to each assert statement
  • Cluster imports into python native & pip installed ones, sort alphabetically
  • Make init argument order the same as self member assignment in NgramModel for consistency sake
  • Add tqdm for tracking progress -> con: new dependency, pro: much nicer to understand the run progress
  • Add caching of best hyperparams (mini optimization)
  • Add get_prob_distribution to the api
  • Use f-strings to print
  • Use map for repetitive work

Additionally:

  • Add environment.yaml so we can use a single python command to install all dependencies into a conda env. Otherwise users will additionally have to install matplotlib and ipykernel if they run the jupyter notebook script. This additionally allows us to nicely track the versioning information in the future.
  • Add .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant