Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mini refactor:
NgramModel
for consistency saketqdm
for tracking progress -> con: new dependency, pro: much nicer to understand the run progressget_prob_distribution
to the apiAdditionally:
environment.yaml
so we can use a single python command to install all dependencies into a conda env. Otherwise users will additionally have to installmatplotlib
andipykernel
if they run the jupyter notebook script. This additionally allows us to nicely track the versioning information in the future.