Skip to content

fix: pre-push hook exit 0 on success path - #8

Merged
EtanHey merged 1 commit into
mainfrom
fix/pre-push-exit0
Apr 27, 2026
Merged

EtanHey merged 1 commit into
mainfrom
fix/pre-push-exit0

Conversation

@EtanHey

@EtanHey EtanHey commented Apr 27, 2026 •

Copy link
Copy Markdown
Owner

Sister PR to voicelayer manaflow-ai#182. EtanHey/cmux fork hook had same fall-off-end bug — script ends with fi and no trailing exit 0, so on success path bash returned the [-test's exit 1.

Fix: append exit 0 at end of .githooks/pre-push.

Pushed with --no-verify (one-time, hook fixes itself).

Source: brainbar-85cb1121-307 (recipe).

Note: systemsCodex worker also opened upstream PR manaflow-ai#3192 against manaflow-ai/cmux as a courtesy contribution. This one is for the EtanHey fork.


Note

Low Risk
Low risk: adds an explicit success exit to the git pre-push hook to avoid accidental non-zero returns; no production code paths are affected.

Overview
Fixes the .githooks/pre-push success path by explicitly exit 0 after the regression harness passes, preventing the hook from falling off the end and incorrectly blocking pushes.

Reviewed by Cursor Bugbot for commit 707a05e. Bugbot is set up for automated code reviews on this repo. Configure here.

Hook fell off end without exit 0. Sister fix to voicelayer manaflow-ai#182 across 5 layer repos. Recipe: brainbar-85cb1121-307.
@coderabbitai

coderabbitai Bot commented Apr 27, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EtanHey has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 49 minutes and 32 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 07ec5f3c-5ec3-4410-84d9-7f62881e5c73

📥 Commits

Reviewing files that changed from the base of the PR and between 05c6823 and 707a05e.

📒 Files selected for processing (1)
  • .githooks/pre-push
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pre-push-exit0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EtanHey
EtanHey merged commit c82e920 into main Apr 27, 2026
5 of 10 checks passed
@EtanHey
EtanHey deleted the fix/pre-push-exit0 branch April 27, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant