Skip to content

Fix /skull issues on 1.20.4+ #6188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JRoy merged 2 commits into from
Jul 4, 2025
Merged

Fix /skull issues on 1.20.4+ #6188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7ec610
Fix /skull issues on 1.20.4+
JRoy Jun 29, 2025
fd212d7
:tf:
JRoy Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 31 additions & 7 deletions Essentials/src/main/java/com/earth2me/essentials/commands/Commandskull.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import com.google.gson.JsonParser;
import net.ess3.api.TranslatableException;
import org.bukkit.Material;
import org.bukkit.OfflinePlayer;
import org.bukkit.Server;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.SkullMeta;
Expand Down Expand Up @@ -108,7 +109,7 @@ private void editSkull(final User user, final User receive, final ItemStack stac
ess.runTaskAsynchronously(() -> {
// Run this stuff async because it causes an HTTP request

final String shortOwnerName;
String shortOwnerName;
if (URL_VALUE_PATTERN.matcher(owner).matches()) {
if (!playerProfileSupported) {
user.sendTl("unsupportedFeature");
Expand All @@ -129,23 +130,46 @@ private void editSkull(final User user, final User receive, final ItemStack stac

shortOwnerName = owner.substring(0, 7);
} else {
//noinspection deprecation
skullMeta.setOwner(owner);
shortOwnerName = owner;
if (playerProfileSupported) {
try {
PlayerProfile profile = ess.getServer().createPlayerProfile(null, owner);
profile = profile.update().join();

if (profile != null) {
skullMeta.setOwnerProfile(profile);
}
if (skullMeta.getOwnerProfile() == null) {
final OfflinePlayer offline = ess.getServer().getOfflinePlayer(owner);
skullMeta.setOwningPlayer(offline);
}

shortOwnerName = owner;
} catch (final Exception e) {
//noinspection deprecation
skullMeta.setOwner(owner);
shortOwnerName = owner;
}
} else {
//noinspection deprecation
skullMeta.setOwner(owner);
shortOwnerName = owner;
}
}
skullMeta.setDisplayName("§fSkull of " + shortOwnerName);

final String shortNameFinal = shortOwnerName;

ess.scheduleSyncDelayedTask(() -> {
stack.setItemMeta(skullMeta);
if (spawn) {
Inventories.addItem(receive.getBase(), stack);
receive.sendTl("givenSkull", shortOwnerName);
receive.sendTl("givenSkull", shortNameFinal);
if (user != receive) {
user.sendTl("givenSkullOther", receive.getDisplayName(), shortOwnerName);
user.sendTl("givenSkullOther", receive.getDisplayName(), shortNameFinal);
}
return;
}
user.sendTl("skullChanged", shortOwnerName);
user.sendTl("skullChanged", shortNameFinal);
});
});
}
Expand Down
Loading