Add setting to use usernames over display names for social spy #5613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
Author
|
Rebased and retested successfully. |
JRoy
approved these changes
Feb 26, 2024
JRoy
changed the title
HarvelsX
pushed a commit
to HarvelsX/Essentials
that referenced
this pull request
Jun 2, 2024
…tialsX#5613) Co-authored-by: Bobcat00 <[email protected]> Co-authored-by: Josh Roy <[email protected]>
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
…tialsX#5613) Co-authored-by: Bobcat00 <[email protected]> Co-authored-by: Josh Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #1995 from 5 years and 8 months ago.
Details
Proposed feature:
Add a config file option for Social Spy to use either display names (the default) or player names in its output.
Also fix a bug which has been present for 6+ years wheresocialMutedSpyPrefixshould have beensocialSpyMutedPrefix.(This was fixed in 2.x with the Adventure changes.)
Environments tested:
OS: Linux 4.15.0-213-generic
Java version: Oracle 17.0.8+9-LTS-211
Demonstration:
Sample output with
socialspy-uses-displaynames: true(the current behavior and default):Sample output with
socialspy-uses-displaynames: false:I'll note that I find the second version to be much more readable.