Skip to content

fix(accordion-item): align focus styles across browsers #9944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcfranco merged 1 commit into from
Aug 7, 2024
Merged

fix(accordion-item): align focus styles across browsers #9944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 21 additions & 22 deletions packages/calcite-components/src/components/accordion-item/accordion-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,12 @@
}

// focus styles
:host .header-content {
.header-content {
@apply focus-base;
}

:host(:focus) .header-content {
@apply focus-inset
outline-none;
.header-content:focus {
@apply focus-inset;
}

:host([expanded]) {
Expand All @@ -58,11 +57,11 @@
}

// .header / content
:host .header {
.header {
@apply flex items-stretch;
}

:host .icon {
.icon {
@apply text-color-3
relative
m-0
Expand Down Expand Up @@ -92,26 +91,26 @@
padding: var(--calcite-accordion-item-padding);
}

:host .content,
:host .header {
.content,
.header {
border-block-end: 1px solid var(--calcite-accordion-item-border, theme("borderColor.color.2"));
}

:host .header * {
.header * {
@apply inline-flex
items-center
duration-150
ease-in-out;
@include word-break();
}

:host .content {
.content {
@apply text-color-3 hidden pt-0;
text-align: initial;
}

// accordion item icon
:host .expand-icon {
.expand-icon {
@apply text-color-3;
margin-inline-start: var(--calcite-accordion-item-icon-spacing-start);
margin-inline-end: var(--calcite-accordion-item-icon-spacing-end);
Expand All @@ -132,26 +131,26 @@
}

// accordion item title
:host .header-text {
.header-text {
@apply my-0 flex-grow flex-col py-0;
text-align: initial;
margin-inline-end: theme("margin.auto");
}

:host .heading,
:host .description {
.heading,
.description {
@apply flex w-full;
}

:host .heading {
.heading {
@apply text-color-2 font-medium;
}
:host .description {
.description {
@apply text-color-3 mt-1;
}

:host(:focus),
:host(:hover) {
.header-content:focus,
.header-content:hover {
& .heading {
@apply text-color-1;
}
Expand All @@ -167,8 +166,8 @@
}
}

:host(:focus),
:host(:active),
.header-content:focus,
.header-content:active,
:host([expanded]) {
& .heading {
@apply text-color-1;
Expand Down Expand Up @@ -202,8 +201,8 @@
font-weight: bolder;
}
}
:host(:hover),
:host(:focus) {
.header-content:hover,
.header-content:focus {
& .heading {
/** give visual indicator of expandability/click-ability since subtle color changes can't be done **/
text-decoration: underline;
Expand Down