Skip to content

feat(dialog): add CSS variables to offset the position #9904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driskull merged 3 commits into from
Aug 14, 2024
Merged

feat(dialog): add CSS variables to offset the position #9904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c277427
feat(dialog): add CSS variables to offset the position. #9879
driskull Jul 30, 2024
334bc6a
Merge branch 'dev' into dris0000/dialog-offset-vars
driskull Jul 30, 2024
e69d90a
Merge branch 'dev' into dris0000/dialog-offset-vars
driskull Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/calcite-components/src/components/dialog/dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
* @prop --calcite-dialog-content-space: Specifies the padding of the component's content.
* @prop --calcite-dialog-footer-space: Specifies the padding of the component's footer.
* @prop --calcite-dialog-border-color: Specifies the component's border color.
* @prop --calcite-dialog-offset-x: Specifies the horizontal offset of the component.
Copy link
Copy Markdown
Contributor

@macandcheese macandcheese Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offset makes sense to me!

* @prop --calcite-dialog-offset-y: Specifies the vertical offset of the component.
*/

:host {
Expand Down Expand Up @@ -132,7 +134,8 @@ calcite-panel {
opacity-0
shadow-2-sm
z-modal
rounded;
rounded
relative;
-webkit-overflow-scrolling: touch;
visibility: hidden;
transition:
Expand All @@ -143,6 +146,9 @@ calcite-panel {
--calcite-internal-dialog-hidden-position: translate3d(0, 20px, 0);
--calcite-internal-dialog-shown-position: translate3d(0, 0, 0);

inset-inline-start: var(--calcite-dialog-offset-x);
inset-block-start: var(--calcite-dialog-offset-y);

&--opening {
&-idle {
transform: var(--calcite-internal-dialog-hidden-position);
Expand Down
4 changes: 2 additions & 2 deletions packages/calcite-components/src/components/dialog/dialog.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,9 +350,9 @@ export const footerSlot = (): string => html`
</calcite-dialog>
`;

const themedStyle = html` --calcite-dialog-scrim-background-color: purple; --calcite-dialog-size-x: 400px;
const themedStyle = html`--calcite-dialog-scrim-background-color: purple; --calcite-dialog-size-x: 400px;
--calcite-dialog-size-y: 400px; --calcite-dialog-footer-space: 50px; --calcite-dialog-border-color: pink;
--calcite-dialog-content-space: 50px;`;
--calcite-dialog-content-space: 50px; --calcite-dialog-offset-x: 50px; --calcite-dialog-offset-y: -30px;`;

export const themed = (): string =>
html`<calcite-dialog
Expand Down