Skip to content

fix(panel, flow-item): fix footer-padding CSS prop regression #9757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcfranco merged 2 commits into from
Jul 12, 2024
Merged

fix(panel, flow-item): fix footer-padding CSS prop regression #9757

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8fa7c9
fix(panel, flow-item): fix footer-padding CSS prop regression
jcfranco Jul 11, 2024
c320eea
fix padding specificity
jcfranco Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 10 additions & 20 deletions packages/calcite-components/src/components/panel/panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,7 @@
@import "../../assets/styles/header";

:host([scale="s"]) {
.content-top,
.content-bottom,
.footer,
.header-content {
padding: var(--calcite-spacing-sm);
}
--calcite-internal-panel-default-padding: var(--calcite-spacing-sm);

.header-content {
.heading {
Expand All @@ -38,12 +33,7 @@
}

:host([scale="m"]) {
.content-top,
.content-bottom,
.footer,
.header-content {
padding: var(--calcite-spacing-md);
}
--calcite-internal-panel-default-padding: var(--calcite-spacing-md);

.header-content {
.heading {
Expand All @@ -57,12 +47,7 @@
}

:host([scale="l"]) {
.content-top,
.content-bottom,
.footer,
.header-content {
padding: var(--calcite-spacing-xl);
}
--calcite-internal-panel-default-padding: var(--calcite-spacing-xl);

.header-content {
.heading {
Expand All @@ -79,7 +64,6 @@
.content-bottom {
@apply flex items-start self-stretch;

padding: var(--calcite-spacing-md);
border-block-start: 1px solid var(--calcite-color-border-3);
background-color: var(--calcite-color-foreground-1);
}
Expand Down Expand Up @@ -178,11 +162,17 @@
h-full;
}

.content-top,
.content-bottom,
.header-content {
padding: var(--calcite-internal-panel-default-padding);
}

.footer {
@apply flex mt-auto flex-row content-between justify-center items-center bg-foreground-1;

border-block-start: 1px solid var(--calcite-color-border-3);
padding: var(--calcite-spacing-sm);
padding: var(--calcite-panel-footer-padding, var(--calcite-internal-panel-default-padding));
column-gap: 0;
row-gap: var(--calcite-spacing-md);
}
Expand Down