test(color-picker): add component token E2E tests#9737
Merged
jcfranco merged 3 commits intoepic/7180-component-tokensfrom Jul 17, 2024
Merged
Conversation
alisonailea
reviewed
Jul 10, 2024
Contributor
alisonailea
left a comment
There was a problem hiding this comment.
I opened the tests in debugger mode and it looks like several of the tokens are not applied?
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
@alisonailea I've removed some of the unused props you pointed out. Thanks for the catch! ✨🎣✨ Others that were pointed out were working, but not shown up for specific configurations or because there was an issue with styles. I've also fixed these and here's how they're looking:
A couple of questions on ☝️:
|
Contributor
|
Member
Author
|
@alisonailea Updated. Would you mind reviewing this again? 🙏 |
alisonailea
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related Issue: #7180
Summary
✨🧪✨