Skip to content

test(radio-button): add component token E2E tests #9591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcfranco merged 2 commits into from
Jun 18, 2024
Merged

test(radio-button): add component token E2E tests #9591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
042c382
test(radio-button): add component token E2E tests
jcfranco Jun 14, 2024
b826df5
tidy up
jcfranco Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/calcite-components/src/components.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4562,6 +4562,10 @@ export namespace Components {
* Accessible name for the dropdown menu.
*/
"dropdownLabel": string;
/**
* Defines the available placements that can be used when a flip occurs.
*/
"flipPlacements": FlipPlacement[];
/**
* Specifies the kind of the component, which will apply to border and background, if applicable.
*/
Expand All @@ -4574,6 +4578,11 @@ export namespace Components {
* Determines the type of positioning to use for the overlaid content. Using `"absolute"` will work for most cases. The component will be positioned inside of overflowing parent containers and will affect the container's layout. `"fixed"` should be used to escape an overflowing parent container, or when the reference element's `position` CSS property is `"fixed"`.
*/
"overlayPositioning": OverlayPositioning;
/**
* Determines where the component will be positioned relative to the container element.
* @default "bottom-end"
*/
"placement": MenuPlacement;
/**
* Specifies an icon to display at the end of the primary button.
*/
Expand Down Expand Up @@ -12509,6 +12518,10 @@ declare namespace LocalJSX {
* Accessible name for the dropdown menu.
*/
"dropdownLabel"?: string;
/**
* Defines the available placements that can be used when a flip occurs.
*/
"flipPlacements"?: FlipPlacement[];
/**
* Specifies the kind of the component, which will apply to border and background, if applicable.
*/
Expand All @@ -12529,6 +12542,11 @@ declare namespace LocalJSX {
* Determines the type of positioning to use for the overlaid content. Using `"absolute"` will work for most cases. The component will be positioned inside of overflowing parent containers and will affect the container's layout. `"fixed"` should be used to escape an overflowing parent container, or when the reference element's `position` CSS property is `"fixed"`.
*/
"overlayPositioning"?: OverlayPositioning;
/**
* Determines where the component will be positioned relative to the container element.
* @default "bottom-end"
*/
"placement"?: MenuPlacement;
/**
* Specifies an icon to display at the end of the primary button.
*/
Expand Down
44 changes: 44 additions & 0 deletions packages/calcite-components/src/components/radio-button/radio-button.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ import {
labelable,
reflects,
renders,
themed,
} from "../../tests/commonTests";
import { html } from "../../../support/formatting";
import { getFocusedElementProp } from "../../tests/utils";
import { CSS } from "./resources";

describe("calcite-radio-button", () => {
describe("renders", () => {
Expand Down Expand Up @@ -611,4 +613,46 @@ describe("calcite-radio-button", () => {
);
});
});

describe("theme", () => {
describe("default", () => {
themed("calcite-radio-button", {
"--calcite-radio-button-background-color": {
shadowSelector: `.${CSS.radio}`,
targetProp: "backgroundColor",
},
"--calcite-radio-button-border-radius": {
shadowSelector: `.${CSS.radio}`,
targetProp: "borderRadius",
},
"--calcite-radio-button-border-color": {
shadowSelector: `.${CSS.radio}`,
targetProp: "boxShadow",
},
"--calcite-radio-button-size": [
{
shadowSelector: `.${CSS.radio}`,
targetProp: "blockSize",
},
{
shadowSelector: `.${CSS.radio}`,
targetProp: "maxInlineSize",
},
{
shadowSelector: `.${CSS.radio}`,
targetProp: "minInlineSize",
},
],
});
});

describe("checked", () => {
themed("calcite-radio-button", {
"--calcite-radio-button-border-color": {
shadowSelector: `.${CSS.radio}`,
targetProp: "boxShadow",
},
});
});
});
});
73 changes: 21 additions & 52 deletions packages/calcite-components/src/components/radio-button/radio-button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,17 @@
* These properties can be overridden using the component's tag as selector.
*
* @prop --calcite-radio-button-background-color: Specifies the background color of the component.
* @prop --calcite-radio-button-border-color: Specifies the shadow of the component.
* @prop --calcite-radio-button-border-radius: Specifies the border radius of the component.
* @prop --calcite-radio-button-shadow: Specifies the shadow of the component.
* @prop --calcite-radio-button-size: Specifies the size of the component.
* @prop --calcite-radio-focus: Specifies the focus of the component.
*/

:host {
display: block;
cursor: pointer;

--calcite-internal-radio-button-shadow-spread: 1px;
--calcite-internal-radio-button-border-color-fallback: var(--calcite-color-border-input);
}

.container {
Expand All @@ -29,7 +31,11 @@
all var(--calcite-animation-timing) ease-in-out 0s,
outline 0s,
outline-offset 0s;
box-shadow: var(--calcite-radio-button-shadow, inset 0 0 0 1px var(--calcite-color-border-input));
box-shadow: inset 0 0 0 var(--calcite-internal-radio-button-shadow-spread)
var(
--calcite-radio-button-border-color,
var(--calcite-internal-radio-button-border-color, var(--calcite-internal-radio-button-border-color-fallback))
);
}

:host([scale="s"]) .radio {
Expand All @@ -52,21 +58,14 @@

:host([focused]) {
.radio {
@include focusOutset("--calcite-radio-focus", "--calcite-internal-radio-focus-offset");
}
}

:host([hovered][disabled]) {
.radio {
box-shadow: var(--calcite-radio-button-shadow, inset 0 0 0 1px var(--calcite-color-border-input));
@apply focus-outset;
}
}

:host([hovered]),
:host(:not([checked])[focused]:not([disabled])) {
.radio {
box-shadow: var(--calcite-radio-button-shadow, inset 0 0 0 2px var(--calcite-color-brand));
}
--calcite-internal-radio-button-shadow-spread: 2px;
--calcite-internal-radio-button-border-color-fallback: var(--calcite-color-brand);
}

@include disabled() {
Expand All @@ -77,54 +76,24 @@
}

:host([scale="s"][checked]),
:host([hovered][scale="s"][checked][disabled]) {
.radio {
box-shadow: var(--calcite-radio-button-shadow, inset 0 0 0 4px var(--calcite-color-brand));
}
}

:host([hovered][scale="s"][checked][disabled]),
:host([scale="s"][focused][checked]:not([disabled])) {
.radio {
box-shadow: var(
--calcite-radio-button-shadow,
inset 0 0 0 4px var(--calcite-color-brand),
0 0 0 2px var(--calcite-color-foreground-1)
);
}
--calcite-internal-radio-button-shadow-spread: 4px;
--calcite-internal-radio-button-border-color-fallback: var(--calcite-color-brand);
}

:host([scale="m"][checked]),
:host([hovered][scale="m"][checked][disabled]) {
.radio {
box-shadow: var(--calcite-radio-button-shadow, inset 0 0 0 5px var(--calcite-color-brand));
}
}

:host([hovered][scale="m"][checked][disabled]),
:host([scale="m"][focused][checked]:not([disabled])) {
.radio {
box-shadow: var(
--calcite-radio-button-shadow,
inset 0 0 0 5px var(--calcite-color-brand),
0 0 0 2px var(--calcite-color-foreground-1)
);
}
--calcite-internal-radio-button-shadow-spread: 5px;
--calcite-internal-radio-button-border-color-fallback: var(--calcite-color-brand);
}

:host([scale="l"][checked]),
:host([hovered][scale="l"][checked][disabled]) {
.radio {
box-shadow: var(--calcite-radio-button-shadow, inset 0 0 0 6px var(--calcite-color-brand));
}
}

:host([hovered][scale="l"][checked][disabled]),
:host([scale="l"][focused][checked]:not([disabled])) {
.radio {
box-shadow: var(
--calcite-radio-button-shadow,
inset 0 0 0 6px var(--calcite-color-brand),
0 0 0 2px var(--calcite-color-foreground-1)
);
}
--calcite-internal-radio-button-shadow-spread: 6px;
--calcite-internal-radio-button-border-color-fallback: var(--calcite-color-brand);
}

@media (forced-colors: active) {
Expand Down