fix: add type-fest as dependency due to build error#9317
Merged
Conversation
github-actions
Bot
added
the
chore
benelan
added
the
skip visual snapshots
jcfranco
approved these changes
May 11, 2024
Member
|
Should this use the |
benelan
changed the title
benelan
added a commit
that referenced
this pull request
May 14, 2024
**Related Issue:** #9307 ## Summary Add `type-fest` to the dependencies of `@esri/calcite-components` to prevent build errors. `type-fest` can also be used to simplify/remove the [preact type generator](https://github.com/Esri/calcite-design-system/blob/27a82dcaf8b091c609b3bf765d8c8617c447d8e7/packages/calcite-components/support/preact.ts#L8) in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #9307
Summary
Add
type-festto the dependencies of@esri/calcite-componentsto prevent build errors.type-festcan also be used to simplify/remove the preact type generator in the future.BEGIN_COMMIT_OVERRIDE
fix: add type-fest as dependency due to build error
END_COMMIT_OVERRIDE