Conversation
…-mode` and `input-mode` attributes (#9245) **Related Issue:** #9235 ## Summary This fixes the following issues introduced by #9123 when component props that shadowed global attributes were removed: * the kebab-cased attribute names of those props would no longer work (namely, `enter-key-mode`, `input-mode`) * `autofocus` was missing from component types as Stencil does not include it in the base `HTMLAttribute` type (see stenciljs/core#5726).
github-actions
Bot
added
the
bug
jcfranco
added
the
skip visual snapshots
Member
Author
|
Merging into the |
Merged
geospatialem
modified the milestones:
2024-05-14 - May maintenance release,
2024-05-28 - May Main Release
geospatialem
pushed a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.1</summary> ## [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.8.0...@esri/calcite-components@2.8.1) (2024-05-14) ### Bug Fixes * Add type-fest as dependency due to build error ([3819688](3819688)) * **carousel:** Animate items with the same direction ([#9325](#9325)) ([6bf7b74](6bf7b74)) * **input, input-number, input-text:** Restore `autofocus`, `enter-key-mode` and `input-mode` attributes ([#9245](#9245)) ([#9306](#9306)) ([0498c6e](0498c6e)) * **list-item:** Decrease horizontal spacing between selection icon and content ([#9304](#9304)) ([0e828b6](0e828b6)) </details> <details><summary>@esri/calcite-components-angular: 2.8.1</summary> ## [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.8.0...@esri/calcite-components-angular@2.8.1) (2024-05-14) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> <details><summary>@esri/calcite-components-react: 2.8.1</summary> ## [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.8.0...@esri/calcite-components-react@2.8.1) (2024-05-14) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benelan
pushed a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.8.0...@esri/calcite-components@2.8.1) (2024-05-14) * Add type-fest as dependency due to build error ([3819688](3819688)) * **carousel:** Animate items with the same direction ([#9325](#9325)) ([6bf7b74](6bf7b74)) * **input, input-number, input-text:** Restore `autofocus`, `enter-key-mode` and `input-mode` attributes ([#9245](#9245)) ([#9306](#9306)) ([0498c6e](0498c6e)) * **list-item:** Decrease horizontal spacing between selection icon and content ([#9304](#9304)) ([0e828b6](0e828b6)) </details> <details><summary>@esri/calcite-components-angular: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.8.0...@esri/calcite-components-angular@2.8.1) (2024-05-14) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> <details><summary>@esri/calcite-components-react: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.8.0...@esri/calcite-components-react@2.8.1) (2024-05-14) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Merged
benelan
added a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.8.0...@esri/calcite-components@2.8.1) (2024-05-14) * Add type-fest as dependency due to build error ([3819688](3819688)) * **carousel:** Animate items with the same direction ([#9325](#9325)) ([6bf7b74](6bf7b74)) * **input, input-number, input-text:** Restore `autofocus`, `enter-key-mode` and `input-mode` attributes ([#9245](#9245)) ([#9306](#9306)) ([0498c6e](0498c6e)) * **list-item:** Decrease horizontal spacing between selection icon and content ([#9304](#9304)) ([0e828b6](0e828b6)) </details> <details><summary>@esri/calcite-components-angular: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.8.0...@esri/calcite-components-angular@2.8.1) (2024-05-14) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> <details><summary>@esri/calcite-components-react: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.8.0...@esri/calcite-components-react@2.8.1) (2024-05-14) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> --- This PR was generated with [ReleasePlease](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #9235
Summary
This fixes the following issues introduced by #9123 when component props
that shadowed global attributes were removed:
(namely,
enter-key-mode,input-mode)autofocuswas missing from component types as Stencil does notinclude it in the base
HTMLAttributetype (seebug:
autofocusprop/attr is defined on other HTML attribute types instead ofHTMLAttributesstenciljs/core#5726).