Conversation
|
I was wrong initially, these are all global attributes. |
|
Closing, I think the maquette VDOM library just needs to update its typings to support inputMode, etc. |
benelan
left a comment
There was a problem hiding this comment.
👍
The revert type should only be used when fully reverting a previous commit. Maybe we could use docs or chore instead, since that was the problem this PR resolves? For example:
chore: restore ESLint rule that removed ref for global attributes
|
Imo we should still have these documented if our components don't support all global attributes. |
Could you clarify this @benelan? What do you mean. Our components are web components which are HTML Elements. They do support all global attributes because of that nature. |
|
Okay cool, I wasn't sure if all global attributes were handled correctly or not since this PR was restoring custom logic for two of them. But if all global attributes are handled correctly then we don't need to document them. |
Related Issue: #9235
Summary
"@stencil-community/reserved-member-names": "warn",to eslint config because eslint was preventing commits due to these props being reserved global attributes.