feat(block-section): add icon property (deprecates status)#9194
Merged
feat(block-section): add icon property (deprecates status)#9194
icon property (deprecates status)#9194Conversation
Elijbet
changed the title
github-actions
Bot
added
the
enhancement
Elijbet
added
the
pr ready for visual snapshots
Elijbet
added
pr ready for visual snapshots
jcfranco
reviewed
Apr 26, 2024
jcfranco
approved these changes
Apr 29, 2024
Member
jcfranco
left a comment
jcfranco
left a comment
There was a problem hiding this comment.
Looks great! A few things:
- Let's target this for the May release. The token work might affect it and it'll also give more time for users to prep for the visual changes this will introduce.
- Can you apply the
visual changesto the issue? - Can you rephrase the PR title to be more along the lines of:
feat(component): add X prop (deprecates Y)? We want to highlight the added prop first to align with the commit type.
| flipRtl={iconFlipRtl === "both" || iconFlipRtl === "start"} | ||
| icon={this.iconStart} | ||
| key="icon-start" | ||
| scale="s" |
Contributor
Author
There was a problem hiding this comment.
block/block-section don't have scale currently. It'll be reviewed in #7082. As is, we think of the components that don't have scale as medium and use small icons for them.
jcfranco
approved these changes
Apr 29, 2024
Member
jcfranco
left a comment
jcfranco
left a comment
There was a problem hiding this comment.
Looks great! A few things:
- Let's target this for the May release. The token work might affect it and it'll also give more time for users to prep for the visual changes this will introduce.
- Can you apply the
visual changesto the issue? - Can you rephrase the PR title to be more along the lines of:
feat(component): add X prop (deprecates Y)? We want to highlight the added prop first to align with the commit type.
Elijbet
changed the title
icon property (deprecates status)
jcfranco
approved these changes
May 6, 2024
Member
jcfranco
left a comment
jcfranco
left a comment
There was a problem hiding this comment.
Good to merge once last round of changes are addressed. 🎉
Elijbet
added
pr ready for visual snapshots
Elijbet
added
pr ready for visual snapshots
Elijbet
added
skip visual snapshots
Elijbet
deleted the
elijbet/8110-block-section-deprecate-status-prop-add-icon-prop
branch
Merged
geospatialem
modified the milestones:
2024-05-14 - May maintenance release,
2024-05-28 - May Main Release
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #8110
Summary
Remove the
statusproperty and instead add aniconproperty.Provide a demo and screenshot coverage.