Skip to content

test(alert): added text align centered test#8840

Merged
brandentheintern merged 6 commits intomainfrom
alert-alignText-test
Mar 5, 2024
Merged

test(alert): added text align centered test#8840
brandentheintern merged 6 commits intomainfrom
alert-alignText-test

Conversation

@brandentheintern
Copy link
Copy Markdown
Contributor

@brandentheintern brandentheintern commented Feb 27, 2024 •
edited by jcfranco
Loading

Related Issue: #4636

Summary

Set up a Chromatic test to check if text align center would affect the shadow DOM of the calcite-alert component

@brandentheintern brandentheintern requested a review from a team as a code owner February 27, 2024 20:51
driskull
driskull approved these changes Feb 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Feb 27, 2024
@driskull
Copy link
Copy Markdown
Member

driskull commented Feb 27, 2024

I think this just needs a semantic commit message and semantic PR title.

@brandentheintern brandentheintern changed the title added alignText test feat(alert): added a text alignment test to make sure external styling doesn't affect shadow dom Feb 28, 2024
@github-actions github-actions Bot added the enhancement Issues tied to a new feature or request. label Feb 28, 2024
@brandentheintern brandentheintern changed the title feat(alert): added a text alignment test to make sure external styling doesn't affect shadow dom test(alert): added text align centered test Feb 28, 2024
@github-actions github-actions Bot added the testing Issues related to automated or manual testing. label Feb 28, 2024
@brandentheintern brandentheintern added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed skip visual snapshots Pull requests that do not need visual regression testing. labels Feb 28, 2024
@brandentheintern brandentheintern merged commit 9e1f11a into main Mar 5, 2024
@brandentheintern brandentheintern deleted the alert-alignText-test branch March 5, 2024 21:35
@github-actions github-actions Bot added this to the 2024-03-26 - Mar Release milestone Mar 5, 2024
DitwanP pushed a commit that referenced this pull request Mar 13, 2024
@brandentheintern @DitwanP
test(alert): added text align centered test (#8840)
4e569fe 
**Related Issue:** #4636
Set up a Chromatic test to check if text align center would affect the
shadow DOM of the calcite-alert component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driskull driskull driskull approved these changes

Assignees

@brandentheintern brandentheintern

Labels

enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing. testing Issues related to automated or manual testing.

Projects

None yet

Milestone

2024-03-26 - Mar Release

Development

Successfully merging this pull request may close these issues.

2 participants

@brandentheintern @driskull