Skip to content

feat(tabs): add component tokens#8783

Merged
Elijbet merged 10 commits intoepic/7180-component-tokensfrom
elijbet/7180-add-component-tokens-for-tabs
Feb 28, 2024
Merged

feat(tabs): add component tokens#8783
Elijbet merged 10 commits intoepic/7180-component-tokensfrom
elijbet/7180-add-component-tokens-for-tabs

Conversation

@Elijbet
Copy link
Copy Markdown
Contributor

@Elijbet Elijbet commented Feb 20, 2024

Related Issue: #7180

Summary

Adds the following component tokens:

--calcite-tabs-background-color
--calcite-tabs-border-color

@Elijbet Elijbet changed the title Elijbet/7180 add component tokens for tabs fix(tabs): add component tokens Feb 20, 2024
@Elijbet Elijbet mentioned this pull request Feb 20, 2024
Closed
@alisonailea alisonailea changed the base branch from main to epic/7180-component-tokens February 20, 2024 21:44
@Elijbet Elijbet marked this pull request as ready for review February 23, 2024 01:37
@Elijbet Elijbet requested a review from a team as a code owner February 23, 2024 01:37
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 23, 2024
driskull
driskull approved these changes Feb 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once vars are moved to host.

Comment thread packages/calcite-components/src/components/tabs/tabs.scss
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 25, 2024
@Elijbet Elijbet merged commit c30ab8f into epic/7180-component-tokens Feb 28, 2024
@Elijbet Elijbet deleted the elijbet/7180-add-component-tokens-for-tabs branch February 28, 2024 01:35
@jcfranco jcfranco changed the title fix(tabs): add component tokens feat(tabs): add component tokens Mar 30, 2024
@jcfranco jcfranco mentioned this pull request Mar 30, 2024
Merged
jcfranco added a commit that referenced this pull request Mar 30, 2024
@jcfranco
fix(tabs): use border prop for bordered styling (#8965)
8f18795 
**Related Issue:** #7180 

## Summary

🔳✨🔨

**Note**: this also fixes a regression from
#8783 where
non-bordered tabs displayed a border.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driskull driskull driskull approved these changes

@jcfranco jcfranco jcfranco approved these changes

Assignees

@Elijbet Elijbet

Labels

pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Elijbet @jcfranco @driskull