Skip to content

feat(pagination): Add component tokens#8777

Merged
macandcheese merged 10 commits intoepic/7180-component-tokensfrom
macandcheese/token-update-pagination
Feb 21, 2024
Merged

feat(pagination): Add component tokens#8777
macandcheese merged 10 commits intoepic/7180-component-tokensfrom
macandcheese/token-update-pagination

Conversation

@macandcheese
Copy link
Copy Markdown
Contributor

@macandcheese macandcheese commented Feb 17, 2024

Related Issue: #7180

Summary

--calcite-pagination-background-color-active: Specifies the background color of the pagination items while active.
--calcite-pagination-background-color-hover: Specifies the background color of the pagination items while hovered.
--calcite-pagination-background-color: Specifies the background color of the pagination items.
--calcite-pagination-border-color-hover: Specifies the border color the pagination items while hovered.
--calcite-pagination-border-color-selected: Specifies the border color of the pagination items when selected.
--calcite-pagination-text-color-hover: Specifies the text color of the pagination items items while hovered.
--calcite-pagination-text-color-selected: Specifies the text color of the pagination items when selected.
--calcite-pagination-text-color: Specifies the text color of the pagination items.
--calcite-pagination-arrow-background-color-active: Specifies the background color of the arrow items while active.
--calcite-pagination-arrow-background-color-hover: Specifies the background color of the arrow items while hovered.
--calcite-pagination-arrow-background-color: Specifies the background color of the arrow items.
--calcite-pagination-arrow-icon-color-active: Specifies the icon color of the arrow items while active.
--calcite-pagination-arrow-icon-color-hover: Specifies the icon color of the arrow items while hovered.
--calcite-pagination-arrow-icon-color: Specifies the icon color of the arrow items.

Adds local demo and Chromatic screenshot test.

@macandcheese macandcheese requested a review from a team as a code owner February 17, 2024 20:15
@macandcheese macandcheese changed the title Macandcheese/token update pagination feat(pagination): Add component tokens Feb 17, 2024
@macandcheese macandcheese added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 17, 2024
@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 18, 2024
@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 18, 2024
}

:host([scale="l"]) {
--calcite-internal-pagination-item-size: 44px;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alisonailea Seems like I can't get a variable with this value to work - directly importing the file that has the size-44 reference doesn't seem to work, are any examples of these variables being used in component css files?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do an @import '~@esri/calcite-design-tokens/dist/scss/core.scss'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and used the variable - can I get another look? Thanks

@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 18, 2024
@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 18, 2024
}

:host([scale="l"]) {
--calcite-internal-pagination-item-size: 44px;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do an @import '~@esri/calcite-design-tokens/dist/scss/core.scss'

@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 21, 2024
@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 21, 2024
@macandcheese macandcheese removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 21, 2024
@macandcheese macandcheese added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 21, 2024
@macandcheese macandcheese requested a review from a team February 21, 2024 08:41
@macandcheese macandcheese merged commit 97d77c3 into epic/7180-component-tokens Feb 21, 2024
@macandcheese macandcheese deleted the macandcheese/token-update-pagination branch February 21, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants