Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't override existing validationMessage when displaying after form submission #8690

Merged
merged 7 commits into from
Feb 7, 2024
Merged

fix: don't override existing validationMessage when displaying after form submission #8690

merged 7 commits into from
Feb 7, 2024

Conversation

benelan
Copy link
Member

@benelan benelan commented Feb 3, 2024 •
edited
Loading

Related Issue: #8000

Summary

  • Only set validationMessage property during form submission if it doesn't have an existing value. This allows users to set a custom validation message, which will be displayed instead of the default message provided by the browser.

  • Move the form validation e2e tests to the formAssociated common test, which was requested as a follow up item.

@benelan benelan requested a review from a team as a code owner February 3, 2024 00:00
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 3, 2024
driskull
driskull approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @benelan Just had some feedback.

packages/calcite-components/src/tests/commonTests.ts Outdated Show resolved Hide resolved
packages/calcite-components/src/tests/commonTests.ts
}

function ensureUnchecked(html: string): string {
return html.replace(/(checked|selected)/, "");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully checked and selected are all we need and never more in the future :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, luckily the test would fail if the form submits due to any other attribute existing that satisfies the required restraint. I'm going to write some validation doc once I'm done and I'll note that this function may need to be updated.

packages/calcite-components/src/tests/commonTests.ts Outdated Show resolved Hide resolved
jcfranco
jcfranco approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫
📫📝📝📝📝📫📝📫📫📫📫📫📝📫📝📝📝📝📫📫📝📝📝📫📫📝📝📫📫📝📫📫📫📝📫📝📝📝📝📫📝📫
📫📝📫📫📝📫📝📫📫📫📫📫📝📫📝📫📫📫📫📝📫📫📫📫📝📫📫📝📫📝📝📫📝📝📫📝📫📫📫📫📝📫
📫📝📝📝📝📫📝📫📫📝📫📫📝📫📝📝📝📫📫📫📝📝📫📫📝📫📫📝📫📝📫📝📫📝📫📝📝📝📫📫📝📫
📫📝📫📫📝📫📝📫📝📫📝📫📝📫📝📫📫📫📫📫📫📫📝📫📝📫📫📝📫📝📫📫📫📝📫📝📫📫📫📫📫📫
📫📝📫📫📝📫📫📝📫📫📫📝📫📫📝📝📝📝📫📝📝📝📫📫📫📝📝📫📫📝📫📫📫📝📫📝📝📝📝📫📝📫
📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫📫

@benelan benelan added low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 7, 2024
@benelan benelan merged commit 3076220 into main Feb 7, 2024
17 of 18 checks passed
@benelan benelan deleted the benelan/dont-override-validation-message branch February 7, 2024 22:53
@calcite-admin calcite-admin mentioned this pull request Feb 7, 2024
Merged
benelan added a commit that referenced this pull request Feb 7, 2024
@benelan
Merge branch 'benelan/bump-deps' into benelan/bump-major-deps
5740ced 
* benelan/bump-deps:
  chore: cleanup
  chore: cleanup
  chore: release next
  fix: don't override existing validationMessage when displaying after form submission (#8690)
  build(deps): downgrade broken icons version
  chore: cleanup
  chore: add angular template link to issue templates (#8680)
Elijbet pushed a commit that referenced this pull request Feb 15, 2024
@benelan @Elijbet
fix: don't override existing validationMessage when displaying after …
6131f5f 
…form submission (#8690)

**Related Issue:** #8000 

## Summary

- Only set `validationMessage` property during form submission if it
doesn't have an existing value. This allows users to set a custom
validation message, which will be displayed instead of the default
message provided by the browser.

- Move the form validation e2e tests to the formAssociated common test,
which was [requested as a follow up
item](#8574 (comment)).
jcfranco pushed a commit that referenced this pull request Feb 15, 2024
@calcite-admin @github-actions
chore: release main (#8706)
24b18c8 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-02-15)


### Features

* **stepper:** Add horizontal-single layout
([#8742](#8742))
([c34bc4f](c34bc4f))
* **table:** Add `interactionMode` property to control focus behavior
([#8686](#8686))
([0cb78c0](0cb78c0))
* **table:** Improve accessibility of interaction-mode: static Table
([#8754](#8754))
([eead1b5](eead1b5))
* **tile:** Add responsive layout features
([#8691](#8691))
([f4f872e](f4f872e))


### Bug Fixes

* **color-picker:** Alpha-channel slider scope updates to reflect
current opacity
([#8700](#8700))
([cd0b532](cd0b532))
* **combobox:** Avoid inline-start padding on combobox label when icon
is displayed
([#8672](#8672))
([9eb680a](9eb680a))
* Don't override existing validationMessage when displaying after form
submission
([#8690](#8690))
([3076220](3076220))
* Fix dragging items on a mobile device
([#8751](#8751))
([dc11612](dc11612))
* Fix styling when dragging items on a mobile device
([#8750](#8750))
([7c01e6e](7c01e6e))
* **input, input-number, input-text, text-area:** Ensure all applicable
props are considered in form validation
([#8655](#8655))
([6de8534](6de8534))
* **list-item:** Fix slotted list border styling.
([#8712](#8712))
([855f98d](855f98d))
* **loader:** Optimize animation performance
([#8714](#8714))
([1ed8a01](1ed8a01))
* **preset:** Add back legacy token for calcite-ui-focus-color
([#8694](#8694))
([1d1b933](1d1b933))
* Prevent interaction when component is disabled after initialization
(Firefox)
([#8746](#8746))
([aa84182](aa84182))
* **stepper:** No longer adds default `min-width` for items when
`layout='horizontal'`
([#8758](#8758))
([23a7439](23a7439))


### Reverts

* Fix(panel, flow-item): remove overflow rule
([#8711](#8711))
([21226ce](21226ce))
</details>

<details><summary>@esri/calcite-components-angular: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-02-15)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0
</details>

<details><summary>@esri/calcite-components-react: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-02-15)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@calcite-admin calcite-admin mentioned this pull request May 14, 2024
Merged
@calcite-admin calcite-admin mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@jcfranco jcfranco jcfranco approved these changes

Assignees

@benelan benelan

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-02-27 - Feb Maintenance Release
Development

Successfully merging this pull request may close these issues.
3 participants
@benelan @jcfranco @driskull