feat(progress): add component tokens#8661
Merged
Elijbet merged 6 commits intoepic/7180-component-tokensfrom Feb 21, 2024
Merged
feat(progress): add component tokens#8661Elijbet merged 6 commits intoepic/7180-component-tokensfrom
Elijbet merged 6 commits intoepic/7180-component-tokensfrom
Conversation
Elijbet
changed the title
alisonailea
suggested changes
Jan 29, 2024
Contributor
alisonailea
left a comment
alisonailea
left a comment
There was a problem hiding this comment.
Looks pretty good! Component tokens should be set at :host in most cases.
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
Bot
added
the
Stale
alisonailea
added
design-tokens
alisonailea
approved these changes
Feb 14, 2024
Elijbet
requested review from
benelan,
driskull and
geospatialem
as code owners
Elijbet
force-pushed
the
elijbet/7180-add-component-tokens-for-progress
branch
from
1249127 to
6d54811
Compare
alisonailea
reviewed
Feb 20, 2024
alisonailea
suggested changes
Feb 21, 2024
Contributor
alisonailea
left a comment
alisonailea
left a comment
There was a problem hiding this comment.
One minor thing on text-color. Looks good!
Elijbet
added
the
pr ready for visual snapshots
alisonailea
approved these changes
Feb 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Adds the following component tokens : 🥇