refactor: improve on enforce-ref-last-prop ESLint rule docs #8129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
Elijbet
added
the
skip visual snapshots
Elijbet
requested review from
benelan,
jcfranco,
driskull and
geospatialem
as code owners
benelan
approved these changes
Nov 5, 2023
| @@ -1,6 +1,6 @@ | |||
| # enforce-ref-last-prop | |||
|
|
|||
| This updates `ref` usage to work around a Stencil bug where ref is called in the specified order and not after initializing element with all its attributes/properties. This can cause attributes/properties to be outdated by the time the callback is invoked. | |||
There was a problem hiding this comment.
A couple nitpicks (applies to the other file as well):
This
rule ensures thisis a workaround for ...
... where [the] ref is called ...
... after initializing [the] element ...
... make sure [the] ref attribute ...
|
Revisited messaging: added background info to the rule's doc and went a little shorter for related messaging. |
jcfranco
deleted the
elijbet/7659-refactor-eslint-rule-enforce-ref-last-prop-docs
branch
jcfranco
added a commit
that referenced
this pull request
Nov 9, 2023
**Related Issue:** #7669, #7659 ## Summary Refactor to improve on `enforce-ref-last-prop` ESLint rule docs. --------- Co-authored-by: JC Franco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7669, #7659
Summary
Refactor to improve on
enforce-ref-last-propESLint rule docs.