Skip to content

ci(chromatic): disable animations globally to prevent false positive visual diffs#7348

Merged
benelan merged 2 commits intomainfrom
benelan/chromatic-no-mo-animations
Jul 21, 2023
Merged

ci(chromatic): disable animations globally to prevent false positive visual diffs#7348
benelan merged 2 commits intomainfrom
benelan/chromatic-no-mo-animations

Conversation

@benelan
Copy link
Copy Markdown
Contributor

@benelan benelan commented Jul 20, 2023

Related Issue: #7337 (comment)

Summary

Uses --calcite-duration-factor to disable animations for all snapshots when running in Chromatic.

@benelan benelan requested review from a team, driskull, geospatialem and jcfranco as code owners July 20, 2023 19:27
@github-actions github-actions Bot added the chore Issues with changes that don't modify src or test files. label Jul 20, 2023
@benelan benelan added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jul 20, 2023
Copy link
Copy Markdown
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨🎥✨

@benelan benelan merged commit 883abf1 into main Jul 21, 2023
@benelan benelan deleted the benelan/chromatic-no-mo-animations branch July 21, 2023 17:21
@github-actions github-actions Bot added this to the 2023 July Priorities milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants