test(block): disable loader animation in chromatic snapshots#7333
Merged
test(block): disable loader animation in chromatic snapshots#7333
Conversation
github-actions
Bot
added
the
testing
benelan
added
the
pr ready for visual snapshots
driskull
approved these changes
Jul 18, 2023
Member
driskull
left a comment
driskull
left a comment
There was a problem hiding this comment.
nice!
Maybe we should just set this var for every story?
Contributor
Author
Yeah good call, I'll refactor this PR to do that |
Contributor
Author
|
After looking around for a bit, I haven't found a good way to globally apply this to only the TestOnly stories. I assume we still want animations in the hosted storybook. I'll document this in our conventions for now and I added it to my list to keep digging if/when have some extra time. |
benelan
added a commit
that referenced
this pull request
Jul 20, 2023
**Related Issue:** #7333 ## Summary - Add contributing information about running chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: noticed the failing snapshots in #7327
For example: https://www.chromatic.com/test?appId=6266d45509d7eb004aa254fb&id=64b6d984dc6b56c885b8872f
Summary
Sets the duration factor to 0 in chromatic snapshots to prevent failures due to loader animation