Skip to content

fix(input-date-picker): provides placeholder text context for AT users #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anveshmekala merged 2 commits into from
Jul 14, 2023
Merged

fix(input-date-picker): provides placeholder text context for AT users #7320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9333e96
fix(input-date-picker): provides placeholder text context for AT users
anveshmekala Jul 14, 2023
0b7b596
add message strings for localization
anveshmekala Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...te-components/src/components/input-date-picker/assets/input-date-picker/t9n/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"chooseDate": "Choose date"
"chooseDate": "Choose date",
"dateFormat": "Date Format:"
}
3 changes: 2 additions & 1 deletion ...components/src/components/input-date-picker/assets/input-date-picker/t9n/messages_en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"chooseDate": "Choose date"
"chooseDate": "Choose date",
"dateFormat": "Date Format:"
}
4 changes: 4 additions & 0 deletions packages/calcite-components/src/components/input-date-picker/input-date-picker.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,3 +153,7 @@
}

@include hidden-form-input();

.assistive-text {
@apply sr-only;
}
6 changes: 6 additions & 0 deletions packages/calcite-components/src/components/input-date-picker/input-date-picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,7 @@ export class InputDatePicker
<calcite-input
aria-autocomplete="none"
aria-controls={this.dialogId}
aria-describedby={this.placeholderTextId}
aria-expanded={toAriaBoolean(this.open)}
aria-haspopup="dialog"
class={`input ${
Expand All @@ -550,6 +551,9 @@ export class InputDatePicker
ref={this.setStartInput}
/>
{this.renderToggleIcon(this.open && this.focusedInput === "start")}
<span aria-hidden="true" class={CSS.assistiveText} id={this.placeholderTextId}>
Date Format: {this.localeData?.placeholder}
Copy link
Copy Markdown
Member

@driskull driskull Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be localized right?

Copy link
Copy Markdown
Contributor Author

@anveshmekala anveshmekala Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, updated.

</span>
</div>
<div
aria-hidden={toAriaBoolean(!this.open)}
Expand Down Expand Up @@ -729,6 +733,8 @@ export class InputDatePicker

private valueAsDateChangedExternally = false;

private placeholderTextId = `calcite-input-date-picker-placeholder-${guid()}`;

//--------------------------------------------------------------------------
//
// Private Methods
Expand Down
1 change: 1 addition & 0 deletions packages/calcite-components/src/components/input-date-picker/resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
export const CSS = {
assistiveText: "assistive-text",
menu: "menu-container",
menuActive: "menu-container--active",
toggleIcon: "toggle-icon"
Expand Down