Conversation
benelan
requested review from
driskull,
geospatialem and
jcfranco
as code owners
github-actions
Bot
added
the
chore
benelan
added
the
skip visual snapshots
driskull
approved these changes
Jul 14, 2023
| } | ||
| ] | ||
| "$schema": "https://json.schemastore.org/prettierrc", | ||
| "trailingComma": "none" |
Member
There was a problem hiding this comment.
Dasa recently commented on this in the API channel.
Prettier 3.0 has come out and they've changed the default for trailing commas to "all". We've been using "none", but if there's no objections, I think this would be a good time to switch to "all". It might look odd to some of us at first, but reduces git diffs. Ref: https://prettier.io/docs/en/options.html#trailing-commas
Contributor
Author
There was a problem hiding this comment.
Cool, I prefer all too because it makes it easier to add new items to arrays/objects. I'll switch that one off
benelan
added a commit
that referenced
this pull request
Jul 14, 2023
**Related Issue:** #7318 ## Summary Lint and format the code. Prettier will now add trailing commas when possible, which is the default in 3x. I know already brought up disabling some jsdoc rules in the past, but I think we can at least disable the ` jsdoc/require-param-type` one. We are using TypeScript so defining the types twice seems redundant and likely to get out of sync when things change.
benelan
added a commit
that referenced
this pull request
Jul 18, 2023
## Summary Adds [`.editorconfig`](https://editorconfig.org/#file-format-details) to ensure people's editors have the same settings as prettier. Prettier will get settings from editorconfig if there is one found. This PR also switches to the new Prettier 3x default of adding trailing commas. I linted and nothing else changed except for a few cleanups that also changed w/o the editorconfig. I'll make a separate PR for that. ref: https://prettier.io/docs/en/configuration.html#editorconfig options: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties
benelan
added a commit
that referenced
this pull request
Jul 18, 2023
**Related Issue:** #7318 ## Summary Lint and format the code. Prettier will now add trailing commas when possible, which is the default in 3x. I know already brought up disabling some jsdoc rules in the past, but I think we can at least disable the ` jsdoc/require-param-type` one. We are using TypeScript so defining the types twice seems redundant and likely to get out of sync when things change.
benelan
added a commit
that referenced
this pull request
Jul 18, 2023
…amping-ar-numberingsystem-bug * origin/main: chore(eslint): disable jsdoc/require-param-type rule in favor of typescript (#7326) style: lint and format code (#7319) chore: add editorconfig (#7318) chore: release next fix(input-date-picker): provides placeholder text context for AT users (#7320) chore: release next fix(dropdown-item): provides accessible label when href is not parsed (#7316) ci: create more specific codeowners to limit unnecessary notifications (#7313)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.editorconfigto ensure people's editors have the same settings as prettier. Prettier will get settings from editorconfig if there is one found. This PR also switches to the new Prettier 3x default of adding trailing commas.I linted and nothing else changed except for a few cleanups that also changed w/o the editorconfig. I'll make a separate PR for that.
ref: https://prettier.io/docs/en/configuration.html#editorconfig
options: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties