Skip to content

test: stabilize tests using setFocus #7295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcfranco merged 1 commit into from
Jul 7, 2023
Merged

test: stabilize tests using setFocus #7295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...es/calcite-components/src/components/color-picker-hex-input/color-picker-hex-input.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ describe("calcite-color-picker-hex-input", () => {
await input.setProperty("value", noColorValue);
await page.waitForChanges();
await input.callMethod("setFocus");
await page.waitForChanges();

await page.keyboard.press("ArrowUp");
await page.waitForChanges();
Expand Down Expand Up @@ -525,6 +526,7 @@ describe("calcite-color-picker-hex-input", () => {
await input.setProperty("value", noColorValue);
await page.waitForChanges();
await input.callMethod("setFocus");
await page.waitForChanges();

await page.keyboard.press("ArrowUp");
await page.waitForChanges();
Expand Down
5 changes: 4 additions & 1 deletion packages/calcite-components/src/components/color-picker/color-picker.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ describe("calcite-color-picker", () => {
value: string
): Promise<void> => {
await channelInputOrHexInput.callMethod("setFocus");
await page.waitForChanges();
await selectText(channelInputOrHexInput);
await channelInputOrHexInput.press("Backspace");
await channelInputOrHexInput.type(value);
Expand Down Expand Up @@ -1051,6 +1052,7 @@ describe("calcite-color-picker", () => {

const assertChannelValueNudge = async (page: E2EPage, calciteInput: E2EElement): Promise<void> => {
await calciteInput.callMethod("setFocus");
await page.waitForChanges();
const currentValue = await calciteInput.getProperty("value");

await page.keyboard.press("ArrowUp");
Expand Down Expand Up @@ -1140,7 +1142,6 @@ describe("calcite-color-picker", () => {
});

const assertChannelValueNudge = async (page: E2EPage, calciteInput: E2EElement): Promise<void> => {
await calciteInput.callMethod("setFocus");
await clearAndEnterHexOrChannelValue(page, calciteInput, "");

// using page.waitForChanges as keyboard nudges occur in the next frame
Expand Down Expand Up @@ -1598,6 +1599,7 @@ describe("calcite-color-picker", () => {

const assertChannelValueNudge = async (page: E2EPage, calciteInputOrSlider: E2EElement): Promise<void> => {
await calciteInputOrSlider.callMethod("setFocus");
await page.waitForChanges();
const currentValue = await calciteInputOrSlider.getProperty("value");

function ensureValueType(value: string | number): number | string {
Expand Down Expand Up @@ -1717,6 +1719,7 @@ describe("calcite-color-picker", () => {
}

await calciteInputOrSlider.callMethod("setFocus");
await page.waitForChanges();
await clearValue();

// using page.waitForChanges as keyboard nudges occur in the next frame
Expand Down
1 change: 1 addition & 0 deletions packages/calcite-components/src/components/combobox/combobox.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,6 +783,7 @@ describe("calcite-combobox", () => {
}
} else {
await combobox.callMethod("setFocus");
await page.waitForChanges();
await page.keyboard.press("Escape");
}

Expand Down
2 changes: 2 additions & 0 deletions packages/calcite-components/src/components/dropdown-item/dropdown-item.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,15 @@ describe("calcite-dropdown-item", () => {

calciteDropdownItemSelectEvent = page.waitForEvent("calciteDropdownItemSelect");
await element.callMethod("setFocus");
await page.waitForChanges();
await page.keyboard.press("Enter");
await calciteDropdownItemSelectEvent;

expect(itemChangeSpy).toHaveReceivedEventTimes(2);

calciteDropdownItemSelectEvent = page.waitForEvent("calciteDropdownItemSelect");
await element.callMethod("setFocus");
await page.waitForChanges();
await page.keyboard.press("Space");
await calciteDropdownItemSelectEvent;

Expand Down
2 changes: 2 additions & 0 deletions packages/calcite-components/src/components/dropdown/dropdown.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,7 @@ describe("calcite-dropdown", () => {
expect(calciteDropdownClose).toHaveReceivedEventTimes(0);

await element.callMethod("setFocus");
await page.waitForChanges();
await page.keyboard.press("Space");
await page.waitForChanges();
expect(await dropdownWrapper.isVisible()).toBe(false);
Expand Down Expand Up @@ -799,6 +800,7 @@ describe("calcite-dropdown", () => {
expect(calciteDropdownClose).toHaveReceivedEventTimes(0);

await element.callMethod("setFocus");
await page.waitForChanges();
await page.keyboard.press("Space");
await page.waitForChanges();
expect(await dropdownWrapper.isVisible()).toBe(false);
Expand Down
5 changes: 5 additions & 0 deletions packages/calcite-components/src/components/filter/filter.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ describe("calcite-filter", () => {
it("should clear the value in the input when pressed", async () => {
const filter = await page.find("calcite-filter");
await filter.callMethod("setFocus");
await page.waitForChanges();

await page.keyboard.type("developer");
await page.waitForChanges();
Expand All @@ -118,6 +119,7 @@ describe("calcite-filter", () => {
it("should clear the value in the input when the Escape key is pressed", async () => {
const filter = await page.find("calcite-filter");
await filter.callMethod("setFocus");
await page.waitForChanges();

await page.keyboard.type("developer");
await page.waitForChanges();
Expand Down Expand Up @@ -203,6 +205,7 @@ describe("calcite-filter", () => {

const filterChangeEvent = page.waitForEvent("calciteFilterChange");
await filter.callMethod("setFocus");
await page.waitForChanges();
await filter.type("developer");
await filterChangeEvent;

Expand All @@ -224,6 +227,7 @@ describe("calcite-filter", () => {
const filter = await page.find("calcite-filter");

await filter.callMethod("setFocus");
await page.waitForChanges();
await filter.type("volt");
await waitForEvent;

Expand All @@ -235,6 +239,7 @@ describe("calcite-filter", () => {
const filter = await page.find("calcite-filter");

await filter.callMethod("setFocus");
await page.waitForChanges();
await filter.type("regex()");
await waitForEvent;

Expand Down
Loading