build: make sure eslint-plugin-calcite-components is set up correctly#7294
build: make sure eslint-plugin-calcite-components is set up correctly#7294
Conversation
github-actions
Bot
added
the
chore
|
@jcfranco I had to remove the on-exit cleanup of js demo files from Instead, I clean out all of the js files created by Is that solution okay with you or should I spend more time troubleshooting the concurrency issue? |
| ## Starting the demos | ||
|
|
||
| First, clone the repo and install the NPM dependencies from within the `calcite-components` directory: | ||
| First, clone the repo, install the NPM dependencies: |
There was a problem hiding this comment.
Nitpick: I feel like we need an "and then" between cloning and installing deps. I'll leave this up to you.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "ignorePatterns": ["*"] | |||
There was a problem hiding this comment.
Any package with this configuration will skip linting entirely, right? If so, won't this make the contributing instructions on linting misleading?
There was a problem hiding this comment.
For now, maybe the contributing doc can be updated to indicate that ESLint will only run on calcite-components and we can tweak our linting config to lint properly outside calcite-components after this lands?
There was a problem hiding this comment.
Yeah I added this to CCR and the eslint plugin so eslint won't complain about there not being a config which covers their files.
I'm working on pulling shared eslint/tsconfigs into separate workspaces as part of the lint-staged fix. After that happens, the base eslint config will be used in these packages.
So I'm going to leave the doc as is for now so I don't have to change it and then change it back.
jcfranco
left a comment
jcfranco
left a comment
There was a problem hiding this comment.
Aside from a comment regarding linting on other packages, this LGTM! 🚀
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "ignorePatterns": ["*"] | |||
There was a problem hiding this comment.
For now, maybe the contributing doc can be updated to indicate that ESLint will only run on calcite-components and we can tweak our linting config to lint properly outside calcite-components after this lands?
|
Note: I couldn't get the tsconfig/eslint separating to work at the moment so I updated the doc. See #7122 (comment) |
* origin/main: chore: release next fix(block): loader now appears for all loading cases (#7303) build: update browserslist db (#7301) build(deps): Bump eslint-plugin-jsdoc from 46.2.6 to 46.4.3 (#7306) build(deps): Bump @floating-ui/dom from 1.4.3 to 1.4.4 in /packages/calcite-components (#7305) build(deps): Bump chromatic from 6.19.5 to 6.19.9 (#7308) build(deps): Bump cpy-cli from 4.2.0 to 5.0.0 (#7281) chore: release next feat(text-area): provide additional context for AT users when character limit exceeds (#7299) build(deps): Bump stylelint from 14.16.1 to 15.10.1 (#7296) chore: release next ci: allow lint-staged to find typescript parser config file (#7297) fix(accordion, accordion-item): `icon-position`, `icon-type`, `selection-mode` and `scale` can now be set as props or attributes (#7191) test(stack): stabilize screenshot tests (#7298) build: make sure eslint-plugin-calcite-components is set up correctly (#7294) chore: add translations (#7290) refactor: Ensure all setFocus methods return calls to setFocus (#7287) chore: release next fix(card): ensure teardown logic is called when disconnected (#7289) test: stabilize tests using setFocus (#7295)
**Related Issue:** N/A ## Summary Update doc scripts to no longer reference `cleanOnProcessExit.ts` (removed via #7294).
3 participants
Related Issue: #
Summary
I forgot to mention that the packages within the monorepo are "local dependencies", which means
npm installwon't install them, they have to be built locally. A common workflow iscding directly into calcite-components to do work. This caused issues witheslint-plugin-calcite-componentsbecause it wasn't being built so it wasn't working during development in CC.I added a
startturbo pipeline which will ensure all dependencies are built first. So runningnpm startfrom the root directory will no longer cause this issue.I also cleaned up the Contributing doc and tweaked some eslint settings that were causing issues in VSCode.