Skip to content

ci: double build cc when publishing to workaround stencil types bug #7227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benelan merged 3 commits into from
Jun 27, 2023
Merged

ci: double build cc when publishing to workaround stencil types bug #7227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fda5b9f
ci: double build cc when publishing to workaround types bug
benelan Jun 27, 2023
2f114de
ci: move to support script so it can be doc'd
benelan Jun 27, 2023
162befd
Merge branch 'master' into benelan/publish-stencil-types-workaround
benelan Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/calcite-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"lint:scss": "stylelint --fix \"src/**/*.scss\" && prettier --write \"**/*.scss\" >/dev/null",
"lint:ts": "eslint --ext .ts,.tsx --fix . && prettier --write \"**/*.ts?(x)\" >/dev/null",
"posttest": "npm run test:prerender",
"prepublishOnly": "./support/stencilDoubleBuildTypesWorkaround.sh",
"release:docs": "npm run docs && storybook-to-ghpages --existing-output-dir=docs",
"start": "concurrently --kill-others --raw \"tsc --project ./tsconfig-demos.json --watch\" \"npm run build:watch-dev -- --serve\" \"ts-node --esm ./support/cleanOnProcessExit.ts --path ./src/demos/**/*.js \"",
"test": "stencil test --no-docs --no-build --spec --e2e",
Expand Down
17 changes: 17 additions & 0 deletions packages/calcite-components/support/stencilDoubleBuildTypesWorkaround.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#!/usr/bin/env sh

# This script builds the stencil components and ensures
# the types are generated correctly as a workaround for
# https://github.com/ionic-team/stencil/issues/3239
#
# It runs in the prepublishOnly NPM script hook
# to prevent releasing with type bugs, and because
# it needs to execute after versioning so that the
# preamble in the dist source code is correct.
#
# Refs:
# https://github.com/lerna/lerna/blob/main/libs/commands/publish/README.md#lifecycle-scripts
# https://docs.npmjs.com/cli/v8/using-npm/scripts#life-cycle-scripts
# https://github.com/Esri/calcite-components/pull/4303
npm run build
npm run util:test-types