Conversation
github-actions
Bot
added
the
chore
benelan
added
the
pr ready for visual snapshots
benelan
added
pr ready for visual snapshots
benelan
added
pr ready for visual snapshots
benelan
added
pr ready for visual snapshots
benelan
added
pr ready for visual snapshots
benelan
added
pr ready for visual snapshots
jcfranco
left a comment
jcfranco
left a comment
There was a problem hiding this comment.
This is awesome, @benelan! Thanks for the time and effort on this. 🏆 #hellomonorepoland
💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻
💻🧐💻💻💻🧐💻💻🧐🧐💻💻🧐💻💻💻🧐💻💻🧐🧐💻💻🧐🧐🧐💻💻🧐🧐🧐🧐💻🧐🧐🧐💻💻💻🧐🧐💻💻
💻🧐🧐💻🧐🧐💻🧐💻💻🧐💻🧐🧐💻💻🧐💻🧐💻💻🧐💻🧐💻💻🧐💻🧐💻💻💻💻🧐💻💻🧐💻🧐💻💻🧐💻
💻🧐💻🧐💻🧐💻🧐💻💻🧐💻🧐💻🧐💻🧐💻🧐💻💻🧐💻🧐🧐🧐💻💻🧐🧐🧐💻💻🧐🧐🧐💻💻🧐💻💻🧐💻
💻🧐💻💻💻🧐💻🧐💻💻🧐💻🧐💻💻🧐🧐💻🧐💻💻🧐💻🧐💻🧐💻💻🧐💻💻💻💻🧐💻💻💻💻🧐💻💻🧐💻
💻🧐💻💻💻🧐💻💻🧐🧐💻💻🧐💻💻💻🧐💻💻🧐🧐💻💻🧐💻💻🧐💻🧐🧐🧐🧐💻🧐💻💻💻💻💻🧐🧐💻💻
💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻💻
| @@ -0,0 +1,18 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
Do we need to add cjs too? 🤯 #lintception
There was a problem hiding this comment.
It may not be needed but I like being explicit when dealing with commonjs vs esmodules since it can be a bit of a clustergoof. Would you prefer the file be named .lintstagedrc.js if it doesn't seem to break anything?
There was a problem hiding this comment.
I was commenting about adding a lint filter for cjs and not the filename.
There was a problem hiding this comment.
Ah, my mistake. As we discussed on Teams, we would need to add an eslintrc to the root in order to lint .lintstagedrc.cjs and I'm not sure if that would conflict with the package-specific linting setups.
The next step in the monorepo setup is splitting out the shared eslint configuration and extending it in the individual packages. Once that happens we use the shared eslintrc in the root directory, and include the cjs file.
Here is one of turbo's examples that shows this in practice:
https://github.com/vercel/turbo/tree/main/examples/design-system
We held off on splitting code out of CC for now becaues it makes more sense to make the monorepo transition incrementally. I'll create a follow up issue for splitting out the eslint/tsconfig/storybook/demos.
* origin/master: chore: fix event handler casing (#7108)
benelan
added
pr ready for visual snapshots
**Related Issue:** #6988 ## Summary Fixes a couple release CI issues: 1. We were going to rename `master` to `main` but not sure what happened to that so I changed the branch names back before installing the monorepo PR. However I missed a few in `package.json`. I think it is still going to happen but I want to wait for Franco to get back before pulling the trigger. cc @alisonailea 2. Looks like the Action gets out of sync in a real dev environment rather than my isolated testing. I need to pull before pushing the changelog cleaning. Error: https://github.com/Esri/calcite-components/actions/runs/5191460111/jobs/9359307809#step:5:35
…7153) **Related Issue:** #6988 ## Summary This PR changes the `release-please` PR title to `chore: release latest`. The default is `chore: release master`. It also makes sure a `v` isn't added before the version in git tags. Their schema doc says it doesn't by default, but I'm not convinced (see links below) so I want to hardcode the config value. The `v` being in the tag wouldn't break anything in our CI, but Lerna doesn't add a `v` and we should make sure our tag format is consistent for our consumer's CI. https://github.com/googleapis/release-please/blob/bdd9b0158ce79d958da01ebf54cb6b07925bc125/schemas/config.json#L77-L79 https://github.com/googleapis/release-please/blob/bdd9b0158ce79d958da01ebf54cb6b07925bc125/src/strategies/base.ts#L139
2 participants
Related Issue: #6532
Summary
Transitions to a monorepo using Turbo Repo. The existing files are moved to
packages/calcite-componentsandcalcite-components-reactis added to the repo. For more information see:https://github.com/Esri/calcite-components/wiki/Monorepo