Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(eslint): ignore private/internal code for jsdoc rules #6416

Merged
merged 9 commits into from
Mar 7, 2023
Merged

ci(eslint): ignore private/internal code for jsdoc rules #6416

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b94b7bd
ci(eslint): disable a few jsdoc rules
benelan Feb 3, 2023
7ab4734
Merge branch 'master' into benelan/eslint-jsdoc-rulez
benelan Feb 4, 2023
551051a
Merge branch 'master' into benelan/eslint-jsdoc-rulez
benelan Feb 6, 2023
e45d6c3
ci(eslint): jsdoc rules ignore private/internal blocks
benelan Feb 8, 2023
f2d8185
Merge remote-tracking branch 'origin/master' into benelan/eslint-jsdo…
benelan Feb 8, 2023
afbce42
Merge branch 'master' into benelan/eslint-jsdoc-rulez
benelan Feb 8, 2023
0fe977e
Merge branch 'master' into benelan/eslint-jsdoc-rulez
benelan Feb 24, 2023
8606540
Merge branch 'master' into benelan/eslint-jsdoc-rulez
benelan Mar 6, 2023
5c8b805
Merge branch 'master' into benelan/eslint-jsdoc-rulez
benelan Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,19 @@
"curly": "error",
"jest/expect-expect": "off",
"jest/no-export": "warn",
"jsdoc/require-jsdoc": "off",
"jsdoc/check-tag-names": "off",
"jsdoc/require-jsdoc": "off",
"lines-between-class-members": ["error", "always"],
"no-multiple-empty-lines": ["error", { "max": 1 }],
"no-unneeded-ternary": "error",
"no-eval": "error",
"no-implied-eval": "error",
"no-multiple-empty-lines": [
"error",
{
"max": 1
}
],
"no-new-func": "error",
"no-unneeded-ternary": "error",
"react/forbid-component-props": [
"warn",
{
Expand Down Expand Up @@ -130,6 +135,10 @@
"settings": {
"react": {
"pragma": "h"
},
"jsdoc": {
"ignoreInternal": true,
"ignorePrivate": true
}
}
}