refactor!: enabled delegatesFocus #6056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a8a10f9.
github-actions
bot
added
the
refactor
driskull
approved these changes
Dec 15, 2022
| @@ -184,7 +185,7 @@ export class Filter | |||
| async setFocus(): Promise<void> { | |||
| await componentLoaded(this); | |||
|
|
|||
| focusElement(this.textInput); | |||
| this.el?.focus(); | |||
There was a problem hiding this comment.
Wouldn't this no longer focus the textInput?
There was a problem hiding this comment.
It does focus the Input because it's the first focusable element. I double checked to be sure, putting this in the demos for this branch correctly focuses the Input:
<calcite-filter></calcite-filter>
<script>
customElements.whenDefined("calcite-filter").then(() =>
document.querySelector("calcite-filter").setFocus());
</script>If we call
focus()on a component with delegatesFocus enabled does it automatically focus the first element?
It depends on whether everything is loaded. For example this works, but not without the timeout:
customElements
.whenDefined("calcite-filter")
.then(() => setTimeout(() => document.querySelector("calcite-filter").focus(), 1000));We still need the async setFocus() methods.
* master: (21 commits) 1.0.0-next.685 refactor(modal)!: Renamed property and updated values (#6054) 1.0.0-next.684 refactor(tab-nav, tab-title)!: remove `event.detail` payload from events (#6046) refactor(tree)!: remove `event.detail` payload from events (#6051) docs(changelog): fix breaking change indent levels (#6057) 1.0.0-next.683 refactor(pagination)!: remove `event.detail` payload from events (#6047) refactor(dropdown)!: remove `event.detail` payload from events (#6044) refactor(rating)!: remove `event.detail` payload from events (#6045) refactor(inline-editable,input,input-text,input-number)!: remove deprecated `intl*` properties (#6049) 1.0.0-next.682 refactor(scrim,rating,time-picker,input-time-picker,value-list)!: removed deprecated `intl*`properties (#6053) docs: update component READMEs (#6052) 1.0.0-next.681 refactor(chip,card,combobox,date-picker,flow,flow-item,filter, input-date-picker): remove deprecated `intl*` & accessible label properties (#6041) refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button): remove deprecated `intl*` properties (#5982) 1.0.0-next.680 refactor(popover, dropdown, modal, pick-list-item, value-list-item)!: rename `disable*` properties (#6036) refactor(input-date-picker)!: Remove deprecated calciteDatePickerChange event (#6040) ...
…Esri/calcite-components into benelan/delegatesFocus-no-mock-disabled * 'benelan/delegatesFocus-no-mock-disabled' of github.com:Esri/calcite-components:
benelan
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Removed the
focusIdparameter fromaction-barandaction-pad'ssetFocusmethodfocusIdparamtersetFocusmethod, focus is delegated to the first focusable element.