Conversation
driskull
left a comment
driskull
left a comment
There was a problem hiding this comment.
👍
What are your thoughts on leaving the hydrationStyles file in the codebase for now?
| support/output-targets/custom-elements/bundles/ | ||
| src/**/components.d.ts | ||
| src/**/*.js | ||
| src/assets/styles/_hydration.scss |
There was a problem hiding this comment.
Maybe we can just comment all this stuff out until its ready?
There was a problem hiding this comment.
I'd rather remove the code. Restoring this should be as simple as re-reverting (verting? 😂) the commit.
| /* CSS vars (@include in global) */ | ||
| @import "type"; | ||
|
|
||
| /* Hydration styles to hide non-hydrated components */ |
There was a problem hiding this comment.
Maybe we can just comment this out for now?
| @@ -1,33 +0,0 @@ | |||
| type Dirent = import("fs").Dirent; | |||
There was a problem hiding this comment.
Maybe we can leave this file for now even though it won't be used until its fixed?
benelan
left a comment
benelan
left a comment
There was a problem hiding this comment.
LGTM! I'll release when this is merged. Third time's the charm 🤞
I think verting™️ when the stencil issue is resolved would be easier than remembering which lines in which files to uncomment, as well as remembering to change some of the NPM scripts
|
sounds good! |
jcfranco
deleted the
jcfranco/revert-hydration-style-changes-to-restore-custom-element-output-dir-styling
branch
4 participants
Related Issue: #991
Summary
This rolls back #4856 as it introduced a regression where components from the
dist-custom-elementsbundle do not get displayed since these don't apply thecalcite-hydratedattribute when hydrated (see #991 (comment)). There is an existing Stencil issue related to this, so we should revisit once that gets resolved.This reverts 6405b1f, dae9586.