Skip to content

chore: properly filter non-component files when generating hydration styles #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcfranco merged 2 commits into from
Jul 11, 2022
Merged

chore: properly filter non-component files when generating hydration styles #4897

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14e01e4
chore: properly filter non-component files when generating hydration …
jcfranco Jul 11, 2022
c28d665
tidy up
jcfranco Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions support/hydrationStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
type Dirent = import("fs").Dirent;

const fs = require("fs");
const path = require("path");

const basePath = path.normalize(`${__dirname}/../src/components/`);

async function isCalciteComponent(entry): Promise<boolean> {
async function filter<T>(array: T[], predicate: (item: T) => Promise<boolean>): Promise<T[]> {
const results = await Promise.all(array.map((item) => predicate(item)));
return array.filter((_item, index) => results[index]);
}

async function isCalciteComponent(entry: Dirent): Promise<boolean> {
if (!entry.isDirectory()) {
return false;
}
Expand All @@ -14,12 +21,13 @@ async function isCalciteComponent(entry): Promise<boolean> {
(async function () {
const stylePath = path.normalize(`${__dirname}/../src/assets/styles/_hydration.scss`);
const components = await fs.promises.readdir(basePath, { withFileTypes: true });
const selectors = components.filter(isCalciteComponent).map(({ name }) => `calcite-${name}:not([calcite-hydrated])`);
const selectors = (await filter<Dirent>(components, isCalciteComponent)).map(
({ name }) => `calcite-${name}:not([calcite-hydrated])`
);
const fileContents = `// generated by support/hydrationStyles.ts
${selectors.join(",\n")} {
visibility: hidden;
pointer-events: none;
}`;
await fs.promises.writeFile(stylePath, fileContents);
process.exit(0);
})();