Skip to content

ci(action): cleanup teams release notification#3771

Merged
benelan merged 3 commits intomasterfrom
benelan/cleanup-release-notification
Dec 22, 2021
Merged

ci(action): cleanup teams release notification#3771
benelan merged 3 commits intomasterfrom
benelan/cleanup-release-notification

Conversation

@benelan
Copy link
Copy Markdown
Contributor

@benelan benelan commented Dec 22, 2021

Related Issue: NA

Summary

  • Removed unnecessary 30 min delay
  • Changed the name of the GH secret. Since creating this, I added another teams notification for builds with the secret TEAMS_WEBHOOK_URI_BUILD. So I want to specify that this secret is for release for consistency
  • Added #changelog to the link so you don't have to scroll to find the changes
  • Hardcoded the action version just incase the owner pushes breaking changes to master

@benelan benelan requested a review from a team as a code owner December 22, 2021 01:53
@github-actions github-actions Bot added this to the Sprint 12/20 - 12/31 milestone Dec 22, 2021
Copy link
Copy Markdown
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benelan benelan merged commit 1bffe0d into master Dec 22, 2021
@benelan benelan deleted the benelan/cleanup-release-notification branch December 22, 2021 23:50
benelan added a commit that referenced this pull request Jul 19, 2023
**Original PRs:** #3771 #5512

## Summary

Adding back the Teams release notification action. I had to refactor it
after the monorepo transition so it wouldn't spam the channel with
release notifications for all of the packages.

We can make additional steps for different packages that go to different
channels at some point. For example, a `design-tokens` release
notification to "Get Help - Design and FIGMA"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants