Skip to content

refactor(slider): use refs instead of DOM queries - #15096

Merged
jcfranco merged 1 commit into
devfrom
jcfranco/tidy-up-slider
Sep 1, 2026
Merged

jcfranco merged 1 commit into
devfrom
jcfranco/tidy-up-slider

Conversation

@jcfranco

@jcfranco jcfranco commented Aug 28, 2026 •

Copy link
Copy Markdown
Member

monday.com sync: #12948850056

Related Issue: N/A

Summary

✨🧹✨

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 28, 2026

@aPreciado88 aPreciado88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🧹

@jcfranco jcfranco added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 28, 2026
@jcfranco
jcfranco requested a review from benelan as a code owner August 29, 2026 08:00
@jcfranco
jcfranco force-pushed the jcfranco/tidy-up-slider branch from 0f16822 to a020fd3 Compare August 29, 2026 08:00
@github-actions github-actions Bot added the refactor Issues tied to code that needs to be significantly reworked. label Aug 29, 2026
@jcfranco
jcfranco force-pushed the jcfranco/tidy-up-slider branch from a020fd3 to 9b01a2b Compare August 29, 2026 08:32
@jcfranco
jcfranco force-pushed the jcfranco/tidy-up-slider branch from 9b01a2b to ee3b31c Compare August 31, 2026 16:51
@jcfranco
jcfranco force-pushed the jcfranco/tidy-up-slider branch from ee3b31c to 54859f4 Compare September 1, 2026 15:55
Base automatically changed from jcfranco/migrate-slider-mouse-interaction-tests to dev September 1, 2026 16:30
@jcfranco
jcfranco force-pushed the jcfranco/tidy-up-slider branch from 54859f4 to f72d9f3 Compare September 1, 2026 16:30
@jcfranco
jcfranco merged commit 38ab8ba into dev Sep 1, 2026
12 checks passed
@jcfranco
jcfranco deleted the jcfranco/tidy-up-slider branch September 1, 2026 16:46
benelan added a commit that referenced this pull request Sep 1, 2026
* origin/dev: (47 commits)
  refactor(useFormTrigger): move void controller to constructor (#15108)
  refactor(slider): use refs instead of DOM queries (#15096)
  test(slider): migrate tests to browser mode (#15095)
  refactor: enable `noImplicitAny` (#15027)
  chore: release next
  feat(block): add background color token (#15099)
  fix(tile): restore top/bottom slot spacing (#15101)
  build(deps): update dependency eslint to v10.9.1 (#15036)
  build(deps): update dependency eslint-plugin-storybook to v10.5.10 (#14807)
  build(deps): update dependency @eslint-react/eslint-plugin to v5.18.6 (#14722)
  build(deps): update dependency eslint-plugin-perfectionist to v5.10.1 (#14801)
  build(deps): update dependency @eslint-react/kit to v5.18.6 (#14723)
  refactor: apply `transition-default` mixin (#8851)
  chore: release next
  feat(block): deprecate `collapsible` in favor of `expandable` (#15091)
  chore: release next
  style(radio-button-group): apply linter fixes (#15085)
  fix(radio-button-group): sync group `disabled` only when set (#15084)
  refactor: derive a shared commonTests helper for scale propagation (#15073)
  chore: release next
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants