Skip to content

chore: apply svgo overrides properly#13201

Merged
jcfranco merged 1 commit intodevfrom
jcfranco/fix-svgo-overrides
Oct 27, 2025
Merged

chore: apply svgo overrides properly#13201
jcfranco merged 1 commit intodevfrom
jcfranco/fix-svgo-overrides

Conversation

@jcfranco
Copy link
Copy Markdown
Member

@jcfranco jcfranco commented Oct 27, 2025

Related Issue: N/A

Summary

When SVGO was upgraded to v3 in https://github.com/Esri/calcite-design-system/pull/12415/files#diff-e3f40f8a385daea688f42e92395e25b7cc98377068140f294feaa72b7715cdd8R8-R17, the preset-default overrides were not applied correctly. The overrides need to be defined at the params level per the v2 ➡️ v3 migration notes.

@github-actions github-actions Bot added the chore Issues with changes that don't modify src or test files. label Oct 27, 2025
@calcite-admin calcite-admin added the skip visual snapshots Pull requests that do not need visual regression testing. label Oct 27, 2025
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed skip visual snapshots Pull requests that do not need visual regression testing. labels Oct 27, 2025
@jcfranco jcfranco requested a review from arowles October 27, 2025 02:30
@jcfranco jcfranco marked this pull request as ready for review October 27, 2025 02:30
@jcfranco jcfranco merged commit eb35026 into dev Oct 27, 2025
26 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-svgo-overrides branch October 27, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants