Skip to content

fix(panel, dialog): Calcite dialog header fails to wrap for the longer text #13004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcfranco merged 3 commits into from
Oct 3, 2025
Merged

fix(panel, dialog): Calcite dialog header fails to wrap for the longer text #13004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ece1fb4
fix(panel, dialog): Calcite dialog header fails to wrap for the longe…
driskull Oct 1, 2025
b63b8ba
update story
driskull Oct 1, 2025
d84504e
add delay
driskull Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions packages/calcite-components/src/components/dialog/dialog.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,32 @@ export const withShellInside = (): string =>
<calcite-button slot="footer-end"> Save </calcite-button>
</calcite-dialog>`;

export const withWrappingHeaderText = (): string =>
html`<calcite-dialog
style="--calcite-dialog-max-size-x: 100px"
scale="s"
Copy link
Copy Markdown
Member

@jcfranco jcfranco Oct 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could drop scale, open and description without compromising coverage to simplify the test.

open
heading="Thisisthesongthatneverends...itkeeps goingonnd on my friends...."
description="Heyyy"
>
Dialog Content
</calcite-dialog>`;

withWrappingHeaderText.parameters = {
chromatic: {
delay: 1000,
modes: {
specific: {
viewport: {
width: 1200,
height: 1200,
},
},
},
cropToViewport: true,
},
};

export const themed = (): string =>
html`<calcite-dialog
style="${themedStyle}"
Expand Down
1 change: 1 addition & 0 deletions packages/calcite-components/src/components/panel/panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ slot[name="alerts"]::slotted(calcite-alert) {

.heading-text-content {
flex: 1 1 auto;
overflow: hidden;
}

.heading,
Expand Down
Loading