Skip to content

fix(dialog): Fix for corner radius token #12859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macandcheese merged 3 commits into from
Sep 11, 2025
Merged

fix(dialog): Fix for corner radius token #12859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9d5c97
fix(dialog): Fix for corner radius token
macandcheese Sep 10, 2025
abca229
Merge branch 'dev' into macandcheese/12621-dialog-corner-radius
macandcheese Sep 11, 2025
6cfb6d4
Merge branch 'dev' into macandcheese/12621-dialog-corner-radius
macandcheese Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/calcite-components/src/components/dialog/dialog.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,6 +1346,10 @@ describe("calcite-dialog", () => {
shadowSelector: `.${CSS.panel}`,
targetProp: "--calcite-panel-space",
},
"--calcite-dialog-corner-radius": {
shadowSelector: `.${CSS.panel}`,
targetProp: "--calcite-panel-corner-radius",
},
},
);
});
Expand Down
15 changes: 10 additions & 5 deletions packages/calcite-components/src/components/dialog/dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ calcite-panel {
--calcite-panel-header-content-space: var(--calcite-dialog-header-content-space, var(--calcite-dialog-content-space));
--calcite-panel-footer-space: var(--calcite-dialog-footer-space);
--calcite-popover-border-color: var(--calcite-dialog-action-menu-border-color, var(--calcite-color-border-1));
--calcite-panel-corner-radius: var(--calcite-dialog-corner-radius);
}

:host([kind="brand"]) calcite-panel {
Expand Down Expand Up @@ -197,14 +198,15 @@ calcite-panel {
opacity-0
shadow-2-sm
z-modal
rounded
relative;
-webkit-overflow-scrolling: touch;
visibility: hidden;

transition:
inset-block var(--calcite-internal-animation-timing-slow) $easing-function,
opacity var(--calcite-internal-animation-timing-slow) $easing-function;

border-radius: var(--calcite-dialog-corner-radius, var(--calcite-corner-radius-sm));
min-inline-size: var(--calcite-dialog-min-size-x, var(--calcite-internal-dialog-min-size-x));
max-inline-size: var(--calcite-dialog-max-size-x, 100%);
min-block-size: var(--calcite-dialog-min-size-y, var(--calcite-internal-dialog-min-size-y));
Expand Down Expand Up @@ -233,10 +235,8 @@ calcite-panel {
}

.panel {
@apply invisible
rounded
opacity-0;

@apply invisible opacity-0;
border-radius: var(--calcite-dialog-corner-radius, var(--calcite-corner-radius-sm));
transition:
visibility 0ms linear var(--calcite-internal-animation-timing-slow),
opacity var(--calcite-internal-animation-timing-slow) $easing-function;
Expand Down Expand Up @@ -326,6 +326,11 @@ calcite-panel {
:host([kind]) .panel {
@apply rounded-t-none;
}

:host([kind]) .dialog {
overflow: hidden;
}

:host([kind="brand"]) .dialog {
@apply border-color-brand;
}
Expand Down
Loading