Skip to content

fix(combobox): adjust padding for no-matches context #12781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Elijbet merged 1 commit into from
Aug 27, 2025
Merged

fix(combobox): adjust padding for no-matches context #12781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/calcite-components/src/components/combobox/combobox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
//
// --calcite-internal-close-size
// --calcite-internal-combobox-input-margin-block
// --calcite-internal-combobox-no-matches-spacing-unit-s
Copy link
Copy Markdown
Member

@driskull driskull Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If this were a public var I would suggest naming it --calcite-internal-combobox-no-filtered-items-spacing-unit-s but since its internal it doesn't really matter.

Copy link
Copy Markdown
Contributor Author

@Elijbet Elijbet Aug 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. This is a follow-up PR, so it already has screenshot coverage. Design just had to approve the new padding diffs.

// --calcite-internal-combobox-spacing-unit-l
// --calcite-internal-combobox-spacing-unit-s

Expand All @@ -30,6 +31,7 @@
@apply text-n2;
--calcite-internal-combobox-spacing-unit-l: theme("spacing.2");
--calcite-internal-combobox-spacing-unit-s: theme("spacing.1");
--calcite-internal-combobox-no-matches-spacing-unit-s: theme("spacing.1");
--calcite-combobox-input-height: theme("spacing.4");
--calcite-internal-combobox-input-margin-block: calc(theme("spacing.1") - theme("borderWidth.DEFAULT"));
--calcite-internal-close-size: 1rem;
Expand All @@ -43,6 +45,7 @@
@apply text-n1;
--calcite-internal-combobox-spacing-unit-l: theme("spacing.3");
--calcite-internal-combobox-spacing-unit-s: theme("spacing.2");
--calcite-internal-combobox-no-matches-spacing-unit-s: theme("spacing[1.5]");
--calcite-combobox-input-height: theme("spacing.4");
--calcite-internal-combobox-input-margin-block: calc(theme("spacing.2") - theme("borderWidth.DEFAULT"));
--calcite-internal-close-size: 1.5rem;
Expand All @@ -56,6 +59,7 @@
@apply text-0;
--calcite-internal-combobox-spacing-unit-l: theme("spacing.4");
--calcite-internal-combobox-spacing-unit-s: theme("spacing.3");
--calcite-internal-combobox-no-matches-spacing-unit-s: theme("spacing[2.5]");
--calcite-combobox-input-height: theme("spacing.6");
--calcite-internal-combobox-input-margin-block: calc(theme("spacing[2.5]") - theme("borderWidth.DEFAULT"));
--calcite-internal-close-size: 2rem;
Expand Down Expand Up @@ -260,7 +264,7 @@ calcite-chip {
}

.no-matches {
padding-block: var(--calcite-internal-combobox-spacing-unit-s);
padding-block: var(--calcite-internal-combobox-no-matches-spacing-unit-s);
padding-inline: var(--calcite-internal-combobox-spacing-unit-l);

color: var(--calcite-combobox-input-text-color, var(--calcite-color-text-1));
Expand Down
Loading