Skip to content

test(themed): fail test if token is used as its own target prop #12690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcfranco merged 2 commits into from
Aug 15, 2025
Merged

test(themed): fail test if token is used as its own target prop #12690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d057af4
test(themed): fail test if token is used as its own target prop
jcfranco Aug 12, 2025
28cb350
Merge branch 'dev' into jcfranco/fail-themed-test-if-test-token-is-us…
jcfranco Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/calcite-components/src/tests/commonTests/themed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ export function themed(componentTestSetup: ComponentTestSetup, tokens: Component
throw new Error("Deep piercing via `selector` is not supported, use `shadowSelector` instead");
}

if (token === targetProp) {
throw new Error(
`"${token}" cannot be used as its own targetProp, please use a different property or mapped sub-component token.`,
);
}

const el = await page.find(selector);
const tokenStyle = `${token}: ${setTokens[token]}`;
const target: TargetInfo = { el, selector, shadowSelector, expectedValue };
Expand Down
Loading