Skip to content

chore: restore sass deprecation warning silencing#12640

Merged
jcfranco merged 2 commits intodevfrom
jcfranco/restore-sass-deprecation-warning-silencing
Aug 5, 2025
Merged

chore: restore sass deprecation warning silencing#12640
jcfranco merged 2 commits intodevfrom
jcfranco/restore-sass-deprecation-warning-silencing

Conversation

@jcfranco
Copy link
Copy Markdown
Member

@jcfranco jcfranco commented Aug 5, 2025

Related Issue: N/A

Summary

Restores deprecated warnings prematurely removed in https://github.com/Esri/calcite-design-system/pull/12465/files#diff-50e581eb0e72b23e2222ae7118aad3c0a006d398318cb468fef90c04be473012L77-L82.

Also addresses a new mixed-decls warning introduced in #12516:

@esri/calcite-components:build: Deprecation Warning [mixed-decls]: Sass's behavior for declarations that appear after nested
@esri/calcite-components:build: rules will be changing to match the behavior specified by CSS in an upcoming
@esri/calcite-components:build: version. To keep the existing behavior, move the declaration above the nested
@esri/calcite-components:build: rule. To opt into the new behavior, wrap the declaration in & {}.
@esri/calcite-components:build:
@esri/calcite-components:build: More info: https://sass-lang.com/d/mixed-decls
@esri/calcite-components:build:
@esri/calcite-components:build: ┌──> ../../../../packages/calcite-components/src/components/popover/popover.scss
@esri/calcite-components:build: 22 │ max-inline-size: var(--calcite-popover-max-size-x, 100vw);
@esri/calcite-components:build: │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
@esri/calcite-components:build: ╵
@esri/calcite-components:build: ┌──> ../../../../packages/calcite-components/src/assets/styles/_floating-ui.scss
@esri/calcite-components:build: 94 │ ┌ @starting-style {
@esri/calcite-components:build: 95 │ │ opacity: 0;
@esri/calcite-components:build: 96 │ │ inset-block-start: 0;
@esri/calcite-components:build: 97 │ │ /* stylelint-disable-next-line liberty/use-logical-spec -- explicit position */
@esri/calcite-components:build: 98 │ │ left: 0;
@esri/calcite-components:build: 99 │ │ }
@esri/calcite-components:build: │ └─── nested rule
@esri/calcite-components:build: ╵
@esri/calcite-components:build: ../../../../packages/calcite-components/src/components/popover/popover.scss 22:3 root stylesheet

Note: deprecation silencing will be removed in https://github.com/Esri/calcite-design-system/pull/12216/files#diff-50e581eb0e72b23e2222ae7118aad3c0a006d398318cb468fef90c04be473012.

@github-actions github-actions Bot added the chore Issues with changes that don't modify src or test files. label Aug 5, 2025
@jcfranco jcfranco changed the title chore: restore silencing of sass deprecation warnings chore: restore sass deprecation warning silencing Aug 5, 2025
@include floating-ui-container();
max-inline-size: var(--calcite-popover-max-size-x, 100vw);

& {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driskull I opted into the new behavior to address the warning (produces separate selector), but we should look into updating some mixins to allow some CSS props overrides.

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 5, 2025
Copy link
Copy Markdown
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 7228c7a into dev Aug 5, 2025
19 checks passed
@jcfranco jcfranco deleted the jcfranco/restore-sass-deprecation-warning-silencing branch August 5, 2025 16:26
@github-actions github-actions Bot added this to the 2025-08-26 - Aug Milestone milestone Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants