Skip to content

fix(pagination): restore original default value for totalItems #12569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amretasre002762670 merged 4 commits into from
Jul 24, 2025
Merged

fix(pagination): restore original default value for totalItems #12569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8fd51bf
fix(pagination): restored original default value for totalItems
Amretasre002762670 Jul 23, 2025
439caec
Merge branch 'dev' into Amretasre002762620/PR-amend-12557
Amretasre002762670 Jul 24, 2025
c184e36
Merge branch 'dev' into Amretasre002762620/PR-amend-12557
Amretasre002762670 Jul 24, 2025
3b75d08
Merge branch 'dev' into Amretasre002762620/PR-amend-12557
Amretasre002762670 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/calcite-components/src/components/pagination/pagination.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe("calcite-pagination", () => {
defaults("calcite-pagination", [
{
propertyName: "totalItems",
defaultValue: 1,
defaultValue: 0,
},
{
propertyName: "startItem",
Expand Down
8 changes: 3 additions & 5 deletions packages/calcite-components/src/components/pagination/pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class Pagination extends LitElement {
@property({ reflect: true }) startItem = 1;

/** Specifies the total number of items. */
@property({ reflect: true }) totalItems = 1;
@property({ reflect: true }) totalItems = 0;

//#endregion

Expand Down Expand Up @@ -221,10 +221,8 @@ export class Pagination extends LitElement {
//#region Private Methods

private handleTotalPages(): void {
if (this.pageSize < 1) {
this.pageSize = 1;
}
this.totalPages = this.totalItems / this.pageSize;
this.pageSize = Math.max(1, this.pageSize);
this.totalPages = Math.max(1, this.totalItems / this.pageSize);
}

private effectiveLocaleChange(): void {
Expand Down
Loading