Skip to content

feat(label): add new layout "block" #12552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eriklharper merged 7 commits into from
Jul 23, 2025
Merged

feat(label): add new layout "block" #12552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1bb5b6
refactor(label): replace default layout with block
eriklharper Jul 21, 2025
3ed42e8
updating deprecation message
eriklharper Jul 22, 2025
f418127
Merge branch 'dev' into eriklharper/9184-deprecate-default-layout-wit…
eriklharper Jul 22, 2025
b8a88d2
reverting breaking change to use block as default. Will add this bac…
eriklharper Jul 22, 2025
d40d08e
Merge branch 'dev' into eriklharper/9184-deprecate-default-layout-wit…
eriklharper Jul 22, 2025
1c3e9b4
adding all 3 layout options to simple snapshot test
eriklharper Jul 23, 2025
ddd6e33
Merge branch 'dev' into eriklharper/9184-deprecate-default-layout-wit…
eriklharper Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/calcite-components/src/components/label/label.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
color: var(--calcite-label-text-color, var(--calcite-color-text-1));
}

:host([layout="block"]),
:host([layout="default"]) {
.container {
@apply flex flex-col;
Expand Down
12 changes: 12 additions & 0 deletions packages/calcite-components/src/components/label/label.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,18 @@ export const simple = (): string => html`
Add Notes
<calcite-text-area></calcite-text-area>
</calcite-label>
<calcite-label layout="block">
layout="block"
<calcite-input-text placeholder="I'm below the label"></calcite-input-text>
</calcite-label>
<calcite-label layout="inline">
layout="inline"
<calcite-input-text placeholder="I'm next to the label"></calcite-input-text>
</calcite-label>
<calcite-label layout="inline-space-between">
layout="inline-space-between"
<calcite-input-text placeholder="I'm right aligned"></calcite-input-text>
</calcite-label>
</div>
`;

Expand Down
5 changes: 3 additions & 2 deletions packages/calcite-components/src/components/label/label.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@ export class Label extends LitElement {
/** Specifies the `id` of the component the label is bound to. Use when the component the label is bound to does not reside within the component. */
@property({ reflect: true }) for: string;

/** Defines the layout of the label in relation to the component. Use `"inline"` positions to wrap the label and component on the same line. */
@property({ reflect: true }) layout: "inline" | "inline-space-between" | "default" = "default";
/** Defines the layout of the label in relation to the component. Use `"inline"` positions to wrap the label and component on the same line. [Deprecated] The `"default"` value is deprecated, use `"block"` instead. */
@property({ reflect: true }) layout: "block" | "inline" | "inline-space-between" | "default" =
Comment thread
eriklharper marked this conversation as resolved.
"default";

/** Specifies the size of the component. */
@property({ reflect: true }) scale: Scale = "m";
Expand Down
Loading