refactor(dom): restore currentTarget in slot utils#12477
Merged
Conversation
github-actions
bot
added
the
refactor
jcfranco
added
the
skip visual snapshots
eriklharper
approved these changes
Jul 9, 2025
driskull
approved these changes
Jul 9, 2025
Member
driskull
left a comment
driskull
left a comment
There was a problem hiding this comment.
👍
Any way we can add a test for this so it doesn't get changed again?
Member
Author
|
@driskull Test suite updated! Could you take another look? |
benelan
pushed a commit
that referenced
this pull request
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Restores
currentTargetusage in slot utils introduced in #9768, which was unintentionally removed by https://github.com/Esri/calcite-design-system/pull/9374/files#diff-289d1884a42555c239e4e403d4ea7d10b281307f0eeda6da7e9c573c9bcaffc7.Depending on the slot structure,
targetwill not be the expected slot (see https://codepen.io/jcfranco/pen/WbQegmz).Noteworthy changes
domutil test suite to browser-mode spec testgetStylePixelValuelogic to avoid precision errors causing test failureslotChangeGetAssignedElementsandslotChangeGetAssignedNodestests to use browser - other utils should follow suit